Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various errors can occur due to undefined or incorrect variable names #2741

Closed
ddb4github opened this issue Jun 14, 2019 · 1 comment
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@ddb4github
Copy link
Contributor

Describe the bug

  1. rrdcleaner.php:344: Undefined variable '$width'.
    Maybe ;100%'
  2. managers.php:860: Undefined variable '$manager_id'.
  3. lib/poller.php:1354: Undefined variable '$remote_poller_id'.
  4. graphs.php:741: Undefined variable '$action'.
  5. data_templates.php:153: Undefined variable '$data_template_rrd_id'.
    Maybe "get_filter_request_var('data_template_rrd_id')"
  6. data_templates.php:153: Undefined variable '$data_template_id'.
    Maybe "get_filter_request_var('data_template_id')"
  7. data_debug.php:938: Undefined variable '$host'.

To Reproduce
Review all source code.

@cigamit cigamit changed the title PHP Validation: Part#2 without diff Resolve a number of QA issues in various files Jun 22, 2019
cigamit added a commit that referenced this issue Jun 22, 2019
Resolve a number of QA issues in various files
One additional fix for data debug as to default debug state
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Jun 22, 2019
@cigamit
Copy link
Member

cigamit commented Jun 22, 2019

Great work @ddb4github

@cigamit cigamit added this to the v1.2.5 milestone Jun 23, 2019
@netniV netniV changed the title Resolve a number of QA issues in various files Various errors can occur due to undefined or incorrect variable names Jul 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants