Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempts to close a tooltip when no tooltip has been set may cause errors #2743

Closed
yingbaiibm opened this issue Jun 17, 2019 · 1 comment
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@yingbaiibm
Copy link

Env:
Cacti 1.2.4
FF
rhel7 x64

JS error:
Screen Shot 2019-06-17 at 3 56 48 PM

diff for layout.js
@@ -684,7 +684,9 @@
$(this).tooltip('close');
})
.on('click', function() {

  • $(this).tooltip('close');
  • if($(this).tooltip > -1) {
  • $(this).tooltip('close');
  • }
    });
    $(document).tooltip({
    @@ -4014,5 +4016,3 @@
    }
    }
    }
@yingbaiibm
Copy link
Author

Screen Shot 2019-06-17 at 4 00 02 PM

cigamit added a commit that referenced this issue Jun 22, 2019
Call tooltip('Close') without checking the existence of tooltip
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Jun 22, 2019
@cigamit cigamit added this to the v1.2.5 milestone Jun 23, 2019
@netniV netniV closed this as completed Jun 27, 2019
@netniV netniV changed the title Call tooltip('Close') without checking the existence of tooltip. Attempts to close a tooltip when no tooltip has been set may cause errors Jul 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants