Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate Graphs may sometimes show the wrong row count #2768

Closed
eschoeller opened this issue Jun 27, 2019 · 4 comments
Closed

Aggregate Graphs may sometimes show the wrong row count #2768

eschoeller opened this issue Jun 27, 2019 · 4 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@eschoeller
Copy link

Describe the bug
Any new-style aggregate graphs which use a |query_| in the text_format end up being statically defined instead of dynamic.

To Reproduce
Steps to reproduce the behavior:
Update a data query, and observe that the old value of the |query_| is still present in the aggregate graph, instead of the new queried value.

Expected behavior
When an object in a data query is updated, any references using |query_| should also follow suit.

Additional context
I think I mentioned this in one of my other reports, so if we want to handle it there, that would be ok too. Sorry for the double-post in that case.

@cigamit
Copy link
Member

cigamit commented Jun 27, 2019

Hmm, @eschoeller did I mention that last weekend was a long one. So, the replacements should happen dynamically at render time. If they are not, then we have another bug.

Do me a favor, cut a new database dump, and then let me know which aggregate graph id it impacts. I'll take a look over the weekend.

@cigamit cigamit added the unverified Some days we don't have a clue label Jun 27, 2019
@eschoeller
Copy link
Author

eschoeller commented Jun 28, 2019

Sent you a new DB dump. Take a look at new-style aggregate graph ID 67220.
Here are the aggregate items, all with the correct names:
image
Also note the "1 to 50 of 120" !!! There are not 50 items here, and the next two pages are blank:(
Then here is the graph:
image

Now I go and change the prefix and add an "a" to the end:
image

It is fixed! Then remove the "a":
image

Everything is as it should be.

@cigamit cigamit changed the title [1.2.4] Aggregate Graphs do not dynamically update |query_| text_format directives Aggregate Graphs showing wrong row count Jun 29, 2019
cigamit added a commit that referenced this issue Jun 29, 2019
Aggregate Graphs showing wrong row count
@cigamit
Copy link
Member

cigamit commented Jun 29, 2019

Okay, there were two issues here. The first was the row count, and the second was the updating of the values. I think the second has already been fixed in another bug fix. Just update to develop. And now the second, row count, is fixed.

@cigamit cigamit added bug Undesired behaviour resolved A fixed issue and removed unverified Some days we don't have a clue labels Jun 29, 2019
@cigamit cigamit added this to the v1.2.5 milestone Jun 29, 2019
@cigamit cigamit closed this as completed Jun 30, 2019
@eschoeller
Copy link
Author

OK. So I tried to update to develop earlier today. And it was super rough. So I backed out. I'm back to applying patches manually, which I generally seem to have more success with. I need to improve my git skills.
The row count issue is fixed.
I cannot verify the updating values issue, I can't really seem to find which fix would have addressed this. But I can wait for the official 1.2.5

@netniV netniV changed the title Aggregate Graphs showing wrong row count Aggregate Graphs may sometimes show the wrong row count Jul 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants