Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ItemType is not updated when saving Report Items #2770

Closed
yingbaiibm opened this issue Jun 27, 2019 · 1 comment
Closed

ItemType is not updated when saving Report Items #2770

yingbaiibm opened this issue Jun 27, 2019 · 1 comment
Labels
bug Undesired behaviour reports Reports related issue resolved A fixed issue
Milestone

Comments

@yingbaiibm
Copy link

  1. Add a report
  2. Add a tree item, can not select tree in dropdown list

Screen Shot 2019-06-27 at 5 09 36 PM

cacti 1.2.4
FF
rhel7 x64

@ddb4github
Copy link
Contributor

Temp Solution, copy a block of code lines from later:

--- lib/html_reports.php.src    2019-06-27 17:14:01.446397702 +0800
+++ lib/html_reports.php        2019-06-27 17:11:17.068254266 +0800
@@ -467,6 +467,13 @@
                        array(get_filter_request_var('item_id')));
        }

+       // if a different item_type was selected, use it
+       if (isset_request_var('item_type')) {
+               if (get_filter_request_var('item_type') > 0) {
+                       $report_item['item_type'] = get_request_var('item_type');
+               }
+       }
+
        if (cacti_sizeof($report_item) || $report_item['item_type'] == REPORTS_ITEM_GRAPH) {
                $trees           = array();
                $branches        = array();

@netniV netniV changed the title [Report] Can not select tree when add a tree item in report ItemType is not updated when saving Report Items Jun 27, 2019
@netniV netniV closed this as completed in 7382142 Jun 27, 2019
@netniV netniV added bug Undesired behaviour reports Reports related issue resolved A fixed issue labels Jun 27, 2019
@netniV netniV added this to the v1.2.5 milestone Jun 27, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour reports Reports related issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants