Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a checkbox 'friendly name' has a comma, checkbox functionality stops working #2792

Closed
ddb4github opened this issue Jul 2, 2019 · 0 comments
Closed

When a checkbox 'friendly name' has a comma, checkbox functionality stops working #2792

ddb4github opened this issue Jul 2, 2019 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.5

Comments

@ddb4github
Copy link
Contributor

Describe the bug
checkbox behavior will be incorrect if field friendly_name include a single quot '

  1. uncheck-able if field friendly_name include a extra word for
    2 always show checked if field friendly_name include a extra word checked

To Reproduce
Steps to reproduce the behavior:

  1. edit global_settings.php
  2. modify option show_graph_title-->friendly_name to 'Show's for checked Graph Title'
  3. Access auth_profile.php
  4. Try to click option 'Show's for checked Graph Title'
  5. See error

Workaround
Edit html_form.php, use double quot around $title in html_checkbox function
@cigamit cigamit changed the title checkbox uncheck-able if field friendly_name include a single quot and 'for' Add escaping for checkbox friendly name Jul 2, 2019
cigamit added a commit that referenced this issue Jul 2, 2019
@cigamit
Resolving Issue #2792
15ef911 
Add escaping for checkbox friendly name
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Jul 2, 2019
@cigamit cigamit added this to the v1.2.5 milestone Jul 2, 2019
@cigamit cigamit closed this as completed Jul 2, 2019
@netniV netniV changed the title Add escaping for checkbox friendly name When a checkbox 'friendly name' has a comma, checkbox functionality stops working Jul 14, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.5
Development

No branches or pull requests
2 participants
@cigamit @ddb4github