Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Template can't be edited when it is in use #2845

Closed
rprofijt opened this issue Jul 25, 2019 · 5 comments
Closed

Data Template can't be edited when it is in use #2845

rprofijt opened this issue Jul 25, 2019 · 5 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@rprofijt
Copy link

Describe the bug
After upgrading to 1.2.5 we wanted to change the maximum value in a data template that is being used, on save it gives an "Save Failed due to field input errors" this seems to be because the page thinks the Internal data source name is missing, it is not, but it is greyed out/pre-filled. This does work in 1.1.3.8 and on a data template that is not in use.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to Templates -> Data Source
  2. Click on a data template that is in use and edit the Maximum Value
  3. Click save
  4. See error

Expected behavior
The data template gets edited with the new maximum value

Screenshots
cacti125-datatemplate-bug

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Firefox
  • Version: 67.0.4
@cigamit
Copy link
Member

cigamit commented Jul 25, 2019

Oh, darn. I did not test that. Let me fix it now.

cigamit added a commit that referenced this issue Jul 25, 2019
Data Template can't be edited when it is in use
@cigamit cigamit changed the title 1.2.5 Data Template can't be edited when it is in use Data Template can't be edited when it is in use Jul 25, 2019
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Jul 25, 2019
@cigamit cigamit added this to the v1.2.6 milestone Jul 25, 2019
@cigamit
Copy link
Member

cigamit commented Jul 25, 2019

All fixed up now.

@eholz1
Copy link

eholz1 commented Aug 8, 2019

This does not help me. If I have no devices I have no data source templates. If I add a router or switch, then I get datasources and a datatemplate. I want to change the collection to 5 min for the cpu usage.
My default preset is 1 min. the 5_cpu name is greyed out on the form, and will not let me select the option to allow user to change preset on device creation - How can I do this?

@eholz1
Copy link

eholz1 commented Aug 8, 2019

oops, better forget above comment - found this:
image

@netniV
Copy link
Member

netniV commented Aug 9, 2019

Why do you have so many 1 minute collections to? Do they have different time spans?

@cigamit cigamit closed this as completed Aug 11, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

4 participants