Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tooltips for section headers with 'question' icon #2846

Closed
ddb4github opened this issue Jul 25, 2019 · 0 comments
Closed

Allow tooltips for section headers with 'question' icon #2846

ddb4github opened this issue Jul 25, 2019 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@ddb4github
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Show form tooltip for section header(type=spacer) with 'question' icon

Describe the solution you'd like

  1. support 'description' for 'spacer' item
  2. call display_tooltip function

Additional context

--- html_form.php	2019-07-02 21:43:04.000000690 +0800
+++ html_form.php	2019-07-24 13:27:27.000000453 +0800
@@ -61,7 +61,9 @@
 			} elseif ($field_array['method'] == 'spacer') {
 				$collapsible = (isset($field_array['collapsible']) && $field_array['collapsible'] == 'true');
 
-				print "<div class='spacer formHeader" . ($collapsible ? ' collapsible':'') . "' id='row_$field_name'><div class='formHeaderText'>" . html_escape($field_array['friendly_name']) . ($collapsible ? "<div class='formHeaderAnchor'><i class='fa fa-angle-double-up'></i></div>":'') . '</div></div>';
+				print "<div class='spacer formHeader" . ($collapsible ? ' collapsible':'') . "' id='row_$field_name'><div class='formHeaderText'>" . html_escape($field_array['friendly_name']);
+				print '<div class="formTooltip">' . display_tooltip($field_array['description']) . '</div>';
+				print ($collapsible ? "<div class='formHeaderAnchor'><i class='fa fa-angle-double-up'></i></div>":'') . '</div></div>';
 			} else {
 				// Make a row using a div
 				if (isset($config_array['force_row_color'])) {
@cigamit cigamit added the bug Undesired behaviour label Jul 25, 2019
@cigamit cigamit added this to the v1.2.6 milestone Jul 25, 2019
cigamit added a commit that referenced this issue Jul 25, 2019
Support form tooltip for section header(type=spacer) with 'question' icon
@cigamit cigamit added the resolved A fixed issue label Jul 25, 2019
@cigamit cigamit closed this as completed Aug 11, 2019
@netniV netniV changed the title Support form tooltip for section header(type=spacer) with 'question' icon Allow tooltips for section headers with 'question' icon Sep 1, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants