When attempting to send report, undefined function 'get_tinespan' messages appear

[bmfmancini]

Hello All

Just came across this error even from the dev branch

Call to undefined function get_timespan() for html_reports.php

To fix I # line 810

#get_timespan($timespan, time(), $current_ts, $first_weekdayid);

Everything seems to be working fine after commenting out the line I think it may have been left in there from a deletion

[netniV]

I’m pretty sure there is a standard get_timespan function which converts a time integer to text that I wrote for 1.2.

[bmfmancini]

let me have a look

The reporting function works fine so far with that line commented out
I didnt see a function for it but let me check again

[netniV]

There are different functions for slightly different things but the one above should be in lib/time.php. There is also get_timeinstate() which is for obtaining a human readable string of how long a device was in its current state.

[bmfmancini]

interesting

thanks for the info

[cigamit]

I have been unable to reproduce. Can you please post some of the log messages you are receiving?

[bmfmancini]

Sure I will comment out and rerun I'll send it sometime tomorrow

[bmfmancini]

Recently upgraded to 1.2.5 now I see this error

PHP Warning: Invalid argument supplied for foreach() in /var/www/html/cacti/lib/reports.php

[cigamit]

Well, that is odd.

[bmfmancini]

Yeah really weird at least in 1.2.5 the report generates it's just the error that's pops up