Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long hostnames cause template filter to go off page #2888

Closed
bmfmancini opened this issue Aug 9, 2019 · 14 comments
Closed

Long hostnames cause template filter to go off page #2888

bmfmancini opened this issue Aug 9, 2019 · 14 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@bmfmancini
Copy link
Member

Hey Everyone

I notice that when you have a long hostname in a tree that the page doesn't format properly
the template filter gets pushed off the page and you cant select anything

image

it seems after 40 or so characters this happens

if you go to another tree without the long hostname the drop-down still doesn't appear you need to reload the page for it to show-up

Tested this on chrome,firefox

@bmfmancini
Copy link
Member Author

same behaviour is seen in 1.2.5
also with I.E

@bmfmancini
Copy link
Member Author

to re-create create a device like so
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

@cigamit
Copy link
Member

cigamit commented Aug 11, 2019

Is that with a device with a domain name, or just a device name? What if we provide an option to strip domains?

@cigamit cigamit added bug Undesired behaviour enhancement General tag for an enhancement labels Aug 11, 2019
@bmfmancini
Copy link
Member Author

bmfmancini commented Aug 11, 2019 via email

@bmfmancini
Copy link
Member Author

bmfmancini commented Aug 11, 2019 via email

@cigamit cigamit removed the bug Undesired behaviour label Aug 11, 2019
@netniV
Copy link
Member

netniV commented Aug 18, 2019

This is an issue that I raised a long while ago as it also should be resizable on the tree listing of the graphs.

@cigamit
Copy link
Member

cigamit commented Sep 8, 2019

I think we should move the tree panels to flex layout since we don't care about IE10 any longer. That'll fix this issue, and then we can simply set an overflow on the tree div.

@netniV netniV added this to the v1.3.0 milestone Sep 10, 2019
@netniV
Copy link
Member

netniV commented Sep 10, 2019

That sounds like a plan, we should implement that feature in 1.3.

@bmfmancini
Copy link
Member Author

Hey guys is still slated for 1.3 ?

@cigamit
Copy link
Member

cigamit commented Nov 10, 2019

The only thing I would be willing to do is provide a strip domain setting in 1.2.x. Above that, we have a number of major filter enhancements that we plan to make longer term that would accommodate wider columns and full filters on mobile devices. That's all pretty far out right now due to all of our schedulers.

@bmfmancini
Copy link
Member Author

bmfmancini commented Nov 10, 2019 via email

@bmfmancini
Copy link
Member Author

bmfmancini commented Nov 10, 2019 via email

@cigamit
Copy link
Member

cigamit commented Nov 10, 2019

Long hostnames addressed here: #3079

@cigamit
Copy link
Member

cigamit commented Nov 10, 2019

I think this will be fully resolved in 1.2.8. Due to the use of the new changes in the jquery ui select filter.

@cigamit cigamit added resolved A fixed issue bug Undesired behaviour and removed enhancement General tag for an enhancement labels Nov 10, 2019
@cigamit cigamit modified the milestones: v1.3.0, v1.2.8 Nov 10, 2019
@cigamit cigamit changed the title cacti 1.2.4 long hostnames cause template filter to go off page Long hostnames cause template filter to go off page Nov 10, 2019
cigamit added a commit that referenced this issue Nov 10, 2019
* Any tree or branch with a long name force main content off screen
* Long hostnames cause template filter to go off page
* Tree view cuts off at the bottom of page on modern theme
* Introducing new settings Min Tree Width and Max Tree Width in Settings > Visual and User Profile.
* Corrects a major slowdown in graph templates are presented due to removal of very slow textWidth() function.
@cigamit cigamit closed this as completed Nov 10, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants