Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing Color Template does not update Aggregate #2987

Closed
eschoeller opened this issue Sep 29, 2019 · 9 comments
Closed

Changing Color Template does not update Aggregate #2987

eschoeller opened this issue Sep 29, 2019 · 9 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@eschoeller
Copy link

If you make changes to a color template these changes are not reflected in an existing Aggregate using that template until the color template is switched to something else, saved, then switched back, and saved again.
It could be an awful amount of effort to find every graph which uses a particular template and then update all of those graphs for every change that is made to a color template. But it's equally also inconvenient to step through numerous Aggregates and switch around the color templates. Sort of defeats the purpose of using a template in the first place.

@netniV
Copy link
Member

netniV commented Sep 29, 2019

Did you sync the template to the devices/graphs?

@eschoeller
Copy link
Author

Ah, well, I'm not sure that would have any effect? Yes, I know we can now run a sync on a graph template, but I don't see where that will impact the color template the Aggregate graph is using. The graph templates being referenced by these Aggregates is only using one color, whereas the Aggregate has three data sources, so it needs a color template, otherwise it will just draw three lines of the same color.
I can do a step-by-step example if that would help better explain it.

@netniV
Copy link
Member

netniV commented Sep 30, 2019

So effectively, there needs to be a sync color template too? So that once your changes are done and you are happy with it, you can apply it to all?

@cigamit
Copy link
Member

cigamit commented Sep 30, 2019

There is a function push_out_aggregate() that can be called after each save. This is a strait forward change.

@cigamit
Copy link
Member

cigamit commented Sep 30, 2019

The only issue is that the drag and drop actions will delay the page update. So, we might have to add a 'Sync Aggregates' dropdown to make is a smoother experience.

@cigamit cigamit added the bug Undesired behaviour label Sep 30, 2019
@cigamit cigamit added this to the v1.2.8 milestone Oct 1, 2019
cigamit added a commit that referenced this issue Oct 1, 2019
Changing Color Template does not update Aggregate
@cigamit
Copy link
Member

cigamit commented Oct 1, 2019

@eschoeller, please test the 'Sync Aggregates' dropdown.

@cigamit cigamit added the resolved A fixed issue label Oct 1, 2019
@eschoeller
Copy link
Author

Thanks:) I think it might be a bit hard to remember to do, but at least it will be there somewhere. It's always good to peruse through that menu ... reminds you of things you should be doing, or gives you cool ideas about things you could be doing:)
I'm still back on 1.2.6. I'll get up to 1.2.7, make sure I'm all good there, then snag this update. I'll have to re-create the situation, but it should not be difficult:)
I'll just need a little bit of time.

@cigamit cigamit closed this as completed Oct 12, 2019
@eschoeller
Copy link
Author

eschoeller commented Oct 13, 2019

I tested this, and it did not work :(

Color Template '3 Phase 120v, 3 colors' had 0 Aggregate Templates pushed out and 3 Non-Templated Aggregates pushed out

@eschoeller
Copy link
Author

Hey, just checking in on this one too ... not sure if you can see my comments on a closed issue? I couldn't get this to work ...

@cigamit cigamit reopened this Nov 10, 2019
@cigamit cigamit closed this as completed Dec 11, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants