Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing a report, column setting may be ignored incorrectly #2995

Closed
daepunt opened this issue Oct 1, 2019 · 8 comments
Closed

When editing a report, column setting may be ignored incorrectly #2995

daepunt opened this issue Oct 1, 2019 · 8 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@daepunt
Copy link

daepunt commented Oct 1, 2019

When defining a (Nectar) Report, consisting of a Tree Branch, the graphs of that Branch are displayed in one column only, regardless of the Report Columns setting. I would like to have 2 or 4 columns, but the setting does not seem to do anything. I experimented with Custom HTML, Alignment (or Report and Item) and nothing helps. It does work when adding separate Graphs as single Items to the Report, but the beauty of adding a Tree Branch to a Report is that it's easier to add Graphs and apply Sorting etc. I checked up to Cacti 1.2.6 on debian-testing.

@cigamit
Copy link
Member

cigamit commented Oct 2, 2019

That is quite odd. I am able to product multiple columns. Can you show the example item edit and the general tab so we can have context. Thanks.

@cigamit cigamit added the unverified Some days we don't have a clue label Oct 2, 2019
@daepunt
Copy link
Author

daepunt commented Oct 3, 2019

Hi @cigamit!

Thanks for your reply. I have attached screenshots of the general report settings, item edit and preview.

Please let me know if you need anything else.

Best regards,

Dae.
2019-10-03_11-08-21
2019-10-03_11-09-27
2019-10-03_11-10-38

@cigamit
Copy link
Member

cigamit commented Oct 3, 2019

How does it look when you send it? I think what is happening is that you have your user profile setting to 'Expand Devices' which forces each template into a new row. Please verify. It's still a bug. However, this should give you a workaround in the near term anyway.

@cigamit
Copy link
Member

cigamit commented Oct 3, 2019

The reason it's a bug, is we should be giving you that option when you save the Report.

@cigamit cigamit added bug Undesired behaviour and removed unverified Some days we don't have a clue labels Oct 3, 2019
@netniV netniV added this to the v1.2.8 milestone Oct 3, 2019
@daepunt
Copy link
Author

daepunt commented Oct 3, 2019

When I send the report, it shows only one column, just like the preview.
I attached my User Settings. Expand Devices is turned off, although the on/off switch is green :-)

2019-10-03_14-15-14

@cigamit
Copy link
Member

cigamit commented Oct 4, 2019

Okay, thanks for that. Let me see if I can do a workaround to turn off expand devices by default until we can add a column.

@daepunt
Copy link
Author

daepunt commented Oct 4, 2019

Expand Devices is disabled by default, as far as I know.
And I never had it turned on, so it doesn't seem to be related.
A workaround would be nice, though :-)

cigamit added a commit that referenced this issue Oct 5, 2019
Tree Branch Report only displays single column - not multi column
@cigamit cigamit added the resolved A fixed issue label Oct 5, 2019
@cigamit
Copy link
Member

cigamit commented Oct 5, 2019

Okay, this is the way it has been fixed, if you select 'cascade to all tree branches', you will get the behavior that you are seeing. If you unselect 'cascade to all tree branches', all the graphs will be in the column arrangement you desire. You should update lib/html_reports.php and lib/reports.php from the 1.2.x branch.

@cigamit cigamit closed this as completed Oct 12, 2019
@netniV netniV changed the title Tree Branch Report only displays single column - not multi column When editing a report, column setting may be ignored incorrectly Dec 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants