Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing a user, graph options do not properly reflect previously saved settings #2996

Closed
C00kiekiller opened this issue Oct 1, 2019 · 2 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@C00kiekiller
Copy link
Contributor

Describe the bug
Disable the user rights to see the Tree/List/Preview View under the "graph options" with the slider and save the user. The user has the correct rights in the database but the slider still shows enabled but it should be shown as disabled. The slider show all the time enabled no matter to the stored database value.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Console'
  2. Go to 'Configuration'
  3. Click on 'Users'
  4. Go to 'General Tab'
    5 Disable under 'Graph Options' the setting 'User Has Rights to Tree View' with the Slider
  5. Click on 'Save'
  6. Click on the Operation successful popup 'Ok'
  7. See error - The slider was enabled again
  8. When going back to 'user overview' and select the same user again the slider is shown as enabled but the right was correctly disabled

This issue belong to all sliders Tree/List/Preview View under the graph Options no matter which one is disabled.

Expected behavior
When the right was disabled the slider should be shown as disabled.

Screenshots

  • Before save
    2019-10-01 14_15_27-Console -_ Users -_ (Edit)
  • After save and open/edit the user again
    2019-10-01 14_15_50-Console -_ Users -_ (Edit)after

Desktop (please complete the following information):

  • OS: Windows 10 Version 1903 Build 18362.356
  • Browser: chrome, Firefox, Edge
  • Version: always latest

Server

  • OS: Debian 9.9.0
  • Version: Cacti version 1.2.7
  • Database: mysql Ver 15.1 Distrib 10.1.41-MariaDB, for debian-linux-gnu (x86_64) using readline 5.2
  • Webserver: Apache 2
@C00kiekiller C00kiekiller changed the title Graph Options rights value not shown correctly User Graph Options - Rights value not shown correctly Oct 1, 2019
@cigamit
Copy link
Member

cigamit commented Oct 1, 2019

Just confirming. That's pretty bad.

@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Oct 2, 2019
@cigamit
Copy link
Member

cigamit commented Oct 2, 2019

Okay, update lib/html_utility.php and this will be resolved.

cigamit added a commit that referenced this issue Oct 2, 2019
User Graph Options - Rights value not shown correctly
@netniV netniV added this to the v1.2.8 milestone Oct 2, 2019
@cigamit cigamit closed this as completed Oct 12, 2019
@netniV netniV changed the title User Graph Options - Rights value not shown correctly When editing a user, graph options do not properly reflect previously saved settings Dec 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants