Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow legends to be modified for Aggregate Graphs #3013

Closed
frankfer01 opened this issue Oct 7, 2019 · 17 comments
Closed

Allow legends to be modified for Aggregate Graphs #3013

frankfer01 opened this issue Oct 7, 2019 · 17 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@frankfer01
Copy link

Recently I upgraded cacti from 1.2.6 to 1.2.7. In the version 1.2.6 I reported that the legends can't be modified in aggregate graphs with the issue #2951 and you write to me that the solution will be available in the 1.2.7. Today I have to opportunity to upgrade to this version, but is not possible modified legends. In the change log said: " issue#2951: Allow legends to be modified for Aggregate Graphs" but I can't. Yu can explain to me how I can modified legends in aggregate graphs?

@eschoeller
Copy link

+1 on this one.

@cigamit
Copy link
Member

cigamit commented Oct 12, 2019

Well, it's the ability to convert Aggregate graphs to 'non-aggregate' graphs, where you can modify the legend under Console > Management > Graphs instead of Console > Management > Aggregate Graphs.

I'm not sure that there is a good programmatic way to allow legends to be extended right now under the context of a bug fix other than that. I also allowed some 'COMMENT' lines to also be non skippable in the 1.2.x branch due to someone displaying why it should be allowed.

I guess demonstrating by example will help here. What are you trying to accomplish?

@cigamit cigamit added the unverified Some days we don't have a clue label Oct 12, 2019
@eschoeller
Copy link

eschoeller commented Oct 12, 2019 via email

@eschoeller
Copy link

image
I can't understand why the "D6" sensors aren't listed first in this items list. No matter which Reorder Type I try, there is no difference. If you'd like, I'll submit a separate issue for this.

@cigamit
Copy link
Member

cigamit commented Oct 13, 2019

What re-order method did you use? What are the names of these objects? I have a idea.

@cigamit
Copy link
Member

cigamit commented Oct 13, 2019

Yea, this is a separate issue, but nice graph though!

@eschoeller
Copy link

Heh, thanks. I've been digging the black theme, but it's got some quirks that I'll eventually figure out how to reproduce. I'll open another issue.

@frankfer01
Copy link
Author

Ok, let to explain with an example:
I have two graph of two interfaces and I want to create a aggregate graphs:"
image

image

This is the new graph, the legends loose and you cant modified:
image

This are the details:
image

I took your suggestion and convert it to normal graph. Now the graph move from Aggregates to Graphs:
image

At this point, I cant change or modify any legend.
This part it's too important to me, actually I'm using the version 0.8.8b and want to migrate to the new version. In my case it's create aggregate graph of all interface on a router. This graph will be monitored by a NOC to check the fluctuations, but the operator need to see the legends of this unique graph.

@QooGeek
Copy link

QooGeek commented Oct 16, 2019

Yes, the 1.2.x version of graphics aggregation has been very bad, I am currently using the 0.8.8.x series good. 1.2.x version I can't write the code to change to the state I expected.

@frankfer01
Copy link
Author

Nobody knows if in a future version this will be fixed?

@cigamit
Copy link
Member

cigamit commented Nov 9, 2019

@frankfer01, so when you edit the converted graph, you can not edit or move the items? That's a bug for sure. Let me test that out on my system. So far the convert to a normal graph has not been released.

cigamit added a commit that referenced this issue Nov 9, 2019
Allow legends to be modified for Aggregate Graphs
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue and removed unverified Some days we don't have a clue labels Nov 9, 2019
@cigamit
Copy link
Member

cigamit commented Nov 9, 2019

Okay, update graphs.php and now when you edit the aggregate that has been converted to a normal graph, you can now edit all the items.

@cigamit cigamit added this to the v1.2.8 milestone Nov 9, 2019
@frankfer01
Copy link
Author

Thanks @cigamit , how I can get the file graphs.php to make some tests?

@TheWitness
Copy link
Member

Basically simply download the branch 1.2.x and replace all the files.

@cigamit cigamit closed this as completed Nov 29, 2019
@cigamit
Copy link
Member

cigamit commented Nov 29, 2019

I've closed this as I have tested the conversion to a normal graph and it's working just fine.

@frankfer01
Copy link
Author

Hi, it's true, when you convert to normal graph you can edit any items, but if you have a lot of aggregate graphs, is impossible(a lot of work) to modify one by one. It's is possible to the next version of cacti that aggregate graphs work as well like the version 0.8.8.8 ?

@netniV
Copy link
Member

netniV commented Jan 20, 2020

There have been a lot of changes around the system, so unfortunately, things will never be what they once were overnight. But we are constantly trying to improve and make things better so keep the suggestions coming in where we can improve things.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

6 participants