Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation network range with spaces fails validation #3017

Closed
netniV opened this issue Oct 11, 2019 · 0 comments
Closed

Automation network range with spaces fails validation #3017

netniV opened this issue Oct 11, 2019 · 0 comments
Assignees
Labels
automation Automation related issue bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@netniV
Copy link
Member

netniV commented Oct 11, 2019

Describe the bug
If a network range provided to automation contains spaces at the beginning or end, then it is incorrectly reported as failing when it should be trimmed.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Automation'
  2. Click on 'Networks'
  3. Edit a network
  4. Set the range to something such as " 10.1.1.1" or "10.11.12.0/24, 172.172.0.*"
  5. See the error

Expected behavior
In the above example, " 10.1.1.1" should become "10.1.1.1" and "10.11.12.0/24, 172.172.0.*" should be treated as "10.11.12.0/24,172.172.0.*". The code actually splits the ranges by commas, so it would be the individual entry that is trimmed.

@netniV netniV closed this as completed Oct 11, 2019
@netniV netniV self-assigned this Oct 11, 2019
@netniV netniV added automation Automation related issue bug Undesired behaviour resolved A fixed issue labels Oct 11, 2019
@netniV netniV added this to the v1.2.8 milestone Oct 11, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automation Automation related issue bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant