Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User selected language is not always adhered to #3019

Closed
ddb4github opened this issue Oct 11, 2019 · 4 comments
Closed

User selected language is not always adhered to #3019

ddb4github opened this issue Oct 11, 2019 · 4 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@ddb4github
Copy link
Contributor

Describe the bug
user_language is not took effect if user_language is different with browser locale

To Reproduce
Steps to reproduce the behavior:
0. Ensure browser locale is non-en-US, and change admin-->user_language to en_US
2. Access login page, check button, input-field stakeholder is not en-US
3. Login
4. Check top tab, top tab use 'non-en-US'
5. Check auth_profile.php?action=edit
6. User Language field is "English", but interface language is not English.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.
image

ddb4github pushed a commit to ddb4github/cacti that referenced this issue Oct 11, 2019
cigamit pushed a commit that referenced this issue Oct 12, 2019
@cigamit cigamit added this to the v1.2.8 milestone Oct 12, 2019
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Oct 12, 2019
@cigamit
Copy link
Member

cigamit commented Oct 12, 2019

Can you please provide fresh pull request with the modified CHANGELOG for this an the other issue?

@cigamit cigamit changed the title user_language is not took effect if user_language is different with browser locale user_language will not take effect if user_language is different with browser locale Oct 13, 2019
cigamit added a commit that referenced this issue Oct 13, 2019
Missing CHANGELOG updates
@cigamit
Copy link
Member

cigamit commented Oct 13, 2019

Never mind, I did it.

@cigamit cigamit closed this as completed Oct 13, 2019
cigamit added a commit that referenced this issue Oct 13, 2019
Add white space
@ddb4github
Copy link
Contributor Author

More default behavior need to be completed: for case below

  1. default auth_profile.php-->user_language is from settings-->i18n_default_language
  2. default settings-->i18n_default_language is en_US
  3. login page locale depend on browser interface language, e.g. non-en_US

Proposal story as

  • Keep above #3 behavior, change #1 "default auth_profile.php-->user_language to browser UI language(locale)`
  • Or Keep above #1, #2, and change #3 "login page locale always depend on settings-->i18n_default_language"

@netniV
Copy link
Member

netniV commented Oct 21, 2019

Personally, I believe that the order should be User Settings -> Browser -> System Settings. That way there is a fallback default language if the browsers language isn't supported.

@netniV netniV changed the title user_language will not take effect if user_language is different with browser locale User selected language is not always adhered to Dec 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants