Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When clicking highlighted tab, side panel is not always shown/hidden correctly #3023

Closed
ddb4github opened this issue Oct 12, 2019 · 2 comments
Closed

When clicking highlighted tab, side panel is not always shown/hidden correctly #3023

ddb4github opened this issue Oct 12, 2019 · 2 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.8

Comments

@ddb4github
Copy link
Contributor

Describe the bug
Actually, #2910 and #2919 are not resolved.
BTW, Graphs tab has similar issue: Under tree mode , click 'Tree View' will trigger 'Page Reload" but not show/hide tree

To Reproduce
Ref #2910 and #2919

Root Cause
After click a collapsed non-console tab from submenu, and then click another non-default page under current non-console-tab:, current page execute order as:

  • setupResponsiveMenuAndTabs-->loadTopTab: param 'id' is 'tab-xxxx-ellipsis'
    • go thru all tab, include submenu, and mark clicked sub-menu-item with 'selected' class
  • showCurrentTab: param 'id is 'tab-xxxx'
    • Remove sub-menu-item by id 'tab-xxxx-ellipsis'

So 'selected' info is lost.
When click current 'non-console-tab' again, function setupResponsiveMenuAndTabs check fail both for 'selected' and 'same page',

  • Then reload default page instead of show/hide menu

Additional
I fixed non-console-tab issue at first.
I'll try graph-sub-menu issue as soon if non-other guys interest it .
ddb4github pushed a commit to ddb4github/cacti that referenced this issue Oct 12, 2019
Fixed Cacti#3023
de7a6ff
cigamit pushed a commit that referenced this issue Oct 12, 2019
@ddb4github @cigamit
Fixed #3023 (#3024)
ce90c15
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Oct 12, 2019
@cigamit cigamit added this to the v1.2.8 milestone Oct 12, 2019
@cigamit
Copy link
Member

cigamit commented Oct 12, 2019

Can you please provide fresh pull request with the modified CHANGELOG for this an the other issue?

cigamit added a commit that referenced this issue Oct 13, 2019
@cigamit
CHANGELOG for #3019 & #3023
d9eee49 
Missing CHANGELOG updates
@cigamit
Copy link
Member

cigamit commented Oct 13, 2019

Never mind, I did it.

@cigamit cigamit closed this as completed Oct 13, 2019
ddb4github pushed a commit to ddb4github/cacti that referenced this issue Oct 14, 2019
Fixed Cacti#3023 for Graphs tab sub menu
ed9bc25
ddb4github referenced this issue in ddb4github/cacti Oct 15, 2019
Fixed#3023
9d43039 
	Update ChangeLog
	Add global event to auto-close Graph/Ellipsis/Help/User menu
	Potential JS error for previous about var 'hideTabId'
ddb4github referenced this issue in ddb4github/cacti Oct 15, 2019
Fixed#3023: Update ChangeLog
932e126
cigamit pushed a commit that referenced this issue Oct 16, 2019
@ddb4github @cigamit
Fixed #3023 for Graphs tab sub menu (#3031)
9a222fa 
* Fixed #3023 for Graphs tab sub menu

* Fixed#3023
	Update ChangeLog
	Add global event to auto-close Graph/Ellipsis/Help/User menu
	Potential JS error for previous about var 'hideTabId'

* Fixed#3023: Update ChangeLog
@netniV netniV changed the title Non-Console-Tab continuously reload page instead of show/hide menu When clicking highlighted tab, side panel is not always shown/hidden correctly Dec 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.8
Development

No branches or pull requests
2 participants
@cigamit @ddb4github