Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate Graph re-ordering does not work #3027

Closed
eschoeller opened this issue Oct 13, 2019 · 13 comments
Closed

Aggregate Graph re-ordering does not work #3027

eschoeller opened this issue Oct 13, 2019 · 13 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@eschoeller
Copy link

As referenced in #3013

The Aggregate Graph is displayed identically regardless of which Reorder Type is selected:
cacti_graph_67217

I would expect the "*_Inlet_D6" sources to be shifted to the top of the legend.

@cigamit
Copy link
Member

cigamit commented Oct 13, 2019

Please dump your db and send along to developers at cacti dot net.

@eschoeller
Copy link
Author

will do

@eschoeller
Copy link
Author

Sent. p/w is your first name

@cigamit cigamit added the bug Undesired behaviour label Nov 29, 2019
@cigamit
Copy link
Member

cigamit commented Nov 30, 2019

Okay, looking at the code, the options presently don't make any sense. I'll have to make sense of them.

@eschoeller
Copy link
Author

Cool thanks for looking into it! Looks like you’re working this weekend .. I might have some time later today or tomorrow, but I’m currently traveling. If you want another db dump from me let me know, I can whip that together

@cigamit
Copy link
Member

cigamit commented Nov 30, 2019

It was a pain. But I think it's fixed. Uploading shortly.

@cigamit cigamit changed the title Aggregate Graph Re-Ordering Aggregate Graph re-ordering does not work Nov 30, 2019
cigamit added a commit that referenced this issue Nov 30, 2019
Aggregate Graph re-ordering does not work
@cigamit
Copy link
Member

cigamit commented Nov 30, 2019

Okay, so you have to change lib/api_aggregate.php, lib/aggregate.php, and aggregate_templates.php. Then, you have to change something on the template and click save, then change it back to what you want. In your case, it's really the order.

@cigamit cigamit added the resolved A fixed issue label Nov 30, 2019
@eschoeller
Copy link
Author

Applied those updates, I've been playing around with it. I think we might have a regression issue from #2659

@eschoeller
Copy link
Author

Most notably, see this legend:
Screen Shot 2019-11-30 at 3 59 06 PM
I can't get rid of the "Temperature" for each item, and that's what we were working on in #2659 and #2656.
Both sort orders are also putting "10" in front of "6", but I am less worried about that.

@cigamit
Copy link
Member

cigamit commented Dec 1, 2019

Understand about the regression. We need to add an option for including/excluding the Temperature. I'll have to make another commit either tonight or tomorrow.

cigamit added a commit that referenced this issue Dec 1, 2019
* Aggregate Graph re-ordering does not work
* In order to fix the regression had to add one additional column to the aggregate tables.
@cigamit
Copy link
Member

cigamit commented Dec 1, 2019

Okay, to apply this, you need to add a new column to both the aggregate_graphs, and aggregate_graph_templates tables. Look into the install/upgrades/1_2_8.php file for the alter syntax.

Then, from inside the template there is a checkbox below the prefix to allow you to show and hide the original GPRINT title text.

@cigamit
Copy link
Member

cigamit commented Dec 1, 2019

Make sure you provide feedback on the zoom issue too. I'm pretty sure it'll be fixed now if you take the full update (1.2.x branch).

@cigamit cigamit added this to the v1.2.8 milestone Dec 2, 2019
@cigamit
Copy link
Member

cigamit commented Dec 6, 2019

@eschoeller, Any updates?

@cigamit cigamit closed this as completed Dec 11, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants