Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When zooming a graph, unable to reach edge of graph without losing focus #3028

Closed
eschoeller opened this issue Oct 13, 2019 · 10 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@eschoeller
Copy link

I'm not sure if this one is fix-able, but it's been on my radar for quite some time.
When using the highlight graph zooming feature, it's very difficult to get the zoom region to land directly on the edges (start and end) of the graph. If your cursor exceeds the graph image ever so slightly the zoom range is lost.
It would be fantastic if the zoom range would be maintained to the very end (or beginning) of the timespan instead.
Peek 2019-10-13 11-57

@cigamit
Copy link
Member

cigamit commented Oct 13, 2019

Looks limited to Chrome and Edge. Can not reproduce on Firefox.

@cigamit cigamit added the bug Undesired behaviour label Oct 13, 2019
cigamit added a commit that referenced this issue Oct 13, 2019
Graph Zooming to edge of timespan
@cigamit cigamit added the resolved A fixed issue label Oct 13, 2019
@cigamit
Copy link
Member

cigamit commented Oct 13, 2019

Resolved now.

@cigamit cigamit added this to the v1.2.8 milestone Oct 13, 2019
cigamit added a commit that referenced this issue Oct 13, 2019
Need to properly reset zoom.
@eschoeller
Copy link
Author

eschoeller commented Oct 13, 2019

I updated jquery.zoom.js. I can see that firefox has the desired functionality, good to see this is possible because it's SO much easier to use. My version of chrome still doesn't handle this properly though, and has the same issue as before.

Chromium	77.0.3865.90 (Official Build) Built on Ubuntu , running on Ubuntu 18.04 (64-bit)
Revision	58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS	Linux
JavaScript	V8 7.7.299.11
Flash	(Disabled)
User Agent	Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/77.0.3865.90 Chrome/77.0.3865.90 Safari/537.36
Command Line	/usr/lib/chromium-browser/chromium-browser --enable-pinch --flag-switches-begin --flag-switches-end

I will say that this version of chrome works correctly:

Google Chrome   72.0.3626.121 (Official Build) (64-bit) (cohort: Stable)
Revision        da3787ba355f18db7db52abf75c42afb408d656f-refs/branch-heads/3626@{#883}
OS      Windows
JavaScript      V8 7.2.502.28
Flash   32.0.0.114 C:\Users\eric\AppData\Local\Google\Chrome\User Data\PepperFlash\32.0.0.114\pepflashplayer.dll
User Agent      Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/72.0.3626.121 Safari/537.36
Command Line    "C:\Program Files (x86)\Google\Chrome\Application\chrome.exe" --flag-switches-begin --flag-switches-end

IE version 11.0.9600.19301 works OK too.

@cigamit
Copy link
Member

cigamit commented Oct 16, 2019

You have to force the reload of the file. You can't just do an F5 in Chrome. The way I do it is that I point my browser to http://myhost/cacti/include/js/jquery.zoom.js and press enter, and once it shows the javascript, then press F5, after that, you can back button back and the updated JS file will be loaded. It's a pain in the arse, I know.

@netniV
Copy link
Member

netniV commented Oct 17, 2019

If you have the developer tools open, it will normally force a refresh and with Chrome's tools, I think you can even force it to clear cache on every call.

@cigamit cigamit closed this as completed Nov 9, 2019
@eschoeller
Copy link
Author

I'm still seeing a lot of irregularity with zooming and adhering to the set timespan definition. I haven't been able to reproduce the errors precisely and "sum it all up". I'm starting to suspect there's a browser session issue of some sort. I've also been switching between modern and dark themes to see if the theme has anything to do with it. Eventually I hope to open another issue about it all.

@cigamit
Copy link
Member

cigamit commented Nov 28, 2019

Update jquery.zoom.js and I think this will be solved.

@eschoeller
Copy link
Author

zooming to the end of a graph still causes some problems. I'm on a Mac so I'll have to figure out how to capture an active screen grab of the behavior.

@cigamit
Copy link
Member

cigamit commented Dec 1, 2019

Weird. I can not re-produce on any normal Windows based browser now.

@netniV
Copy link
Member

netniV commented Dec 2, 2019

I'm on a Mac so I'll have to figure out how to capture an active screen grab of the behavior.

Cmd+shift+5

@netniV netniV changed the title Graph Zooming to edge of timespan When zooming a graph, unable to reach edge of graph without losing focus Dec 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants