Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When saving settings, ignore remote pollers who have not checked in recently #3047

Closed
thurban opened this issue Oct 24, 2019 · 15 comments
Closed
Labels
bug Undesired behaviour performance Performance related affects big sites resolved A fixed issue
Milestone

Comments

@thurban
Copy link
Contributor

thurban commented Oct 24, 2019

When saving settings it seems like changes are immediately propagated/saved to all remote pollers. This is causing a very long delay before anything can be done again.

Can this be delayed and propagated along the normal sync time ?

This behavior was observed up until Cacti 1.2.7

@netniV
Copy link
Member

netniV commented Oct 24, 2019

This was introduced to ensure remote poller are using the same ones as soon as possible.

@thurban
Copy link
Contributor Author

thurban commented Oct 24, 2019

Which is a good intent but in my case it causes a waiting time of 2 minutes for each small change due to very remote pollers and offline pollers.

It would be nice to be able to disable this immediate sync and use a "sync settings" from the remote pollers view next to the full sync option ?

@netniV
Copy link
Member

netniV commented Oct 24, 2019

I think that could be another useful enhancement

@netniV netniV added the enhancement General tag for an enhancement label Oct 25, 2019
@netniV netniV added this to the v1.3.0 milestone Oct 25, 2019
@cigamit
Copy link
Member

cigamit commented Nov 9, 2019

This can be fixed with a bulk insert. Let's do that instead. It's a minor performance bug.

@cigamit
Copy link
Member

cigamit commented Nov 9, 2019

Looks like it's a bulk insert anyway. @thurban, how long does a save take on your system?

@thurban
Copy link
Contributor Author

thurban commented Nov 9, 2019 via email

@cigamit
Copy link
Member

cigamit commented Nov 9, 2019

Well, we could force a sync of the settings table at the next poll, but that will delay as well. I'll have to give it some thought as to not make things messy.

@thurban
Copy link
Contributor Author

thurban commented Nov 9, 2019 via email

@cigamit
Copy link
Member

cigamit commented Nov 9, 2019

Not a bad idea. Let's do that first.

@cigamit cigamit added bug Undesired behaviour performance Performance related affects big sites and removed enhancement General tag for an enhancement labels Nov 9, 2019
@cigamit cigamit changed the title Delay settings changes propagation to remote pollers When saving settings, ignore remote pollers who have not checked in recently Nov 9, 2019
cigamit added a commit that referenced this issue Nov 9, 2019
When saving settings, ignore remote pollers who have not checked in recently
@cigamit cigamit added the resolved A fixed issue label Nov 9, 2019
@cigamit
Copy link
Member

cigamit commented Nov 9, 2019

Update settings.php and let me know how the performance is now.

@cigamit cigamit modified the milestones: v1.3.0, v1.2.8 Nov 9, 2019
@cigamit
Copy link
Member

cigamit commented Nov 28, 2019

Any updates?

@thurban
Copy link
Contributor Author

thurban commented Nov 28, 2019

Sorry, missed the original request. Will check next week and report back with some numbers.

@cigamit
Copy link
Member

cigamit commented Nov 28, 2019

Thanks. We are releasing this weekend though. I'm pretty sure you will like the performance change though.

@thurban
Copy link
Contributor Author

thurban commented Nov 28, 2019

Ok. Had a quick look at the code change. I'm more then fine with that change.

@cigamit
Copy link
Member

cigamit commented Nov 28, 2019

Okay, I'll close this then. Thanks Thomas!

@cigamit cigamit closed this as completed Nov 28, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour performance Performance related affects big sites resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants