Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When viewing graphs in realtime, undefined variable can be logged for 95th Percentile graphs #3089

Closed
interduo opened this issue Nov 12, 2019 · 6 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@interduo
Copy link
Contributor

2019/11/12 00:32:10 - CMDPHP PHP ERROR NOTICE Backtrace: (/graph_json.php[158]:rrdtool_function_graph(), /lib/rrd.php[1586]:variable_nth_percentile(), /lib/graph_variables.php[430]:nth_percentile(), /lib/graph_variables.php[33]:rrdtool_function_stats(), /lib/graph_variables.php[136]:nth_percentile_fetch_statistics(), /lib/graph_variables.php[208]:CactiErrorHandler())

2019/11/12 00:32:10 - ERROR PHP NOTICE: Undefined index: p95n in file: /var/www/html/cacti/lib/graph_variables.php on line: 208

I dont know how to reproduce that but I found that in error log.

@interduo
Copy link
Contributor Author

./cacti.log-20191031:2019/10/31 13:49:34 - CMDPHP PHP ERROR NOTICE Backtrace:  (/graph_realtime.php[179]:rrdtool_function_graph(), /lib/rrd.php[1586]:variable_nth_percentile(), /lib/graph_variables.php[430]:nth_percentile(), /lib/graph_variables.php[33]:rrdtool_function_stats(), /lib/graph_variables.php[132]:nth_percentile_fetch_statistics(), /lib/graph_variables.php[149]:CactiErrorHandler())
./cacti.log-20191031:2019/10/31 13:49:34 - ERROR PHP NOTICE: Undefined index: values in file: /var/www/html/cacti/lib/graph_variables.php  on line: 149

And this one also is probbably connected with that issue

@interduo
Copy link
Contributor Author

I've found that few times more.
More output probably in correct order.

2019/11/12 00:32:10 - ERROR PHP NOTICE: Undefined index: values in file: /var/www/html/cacti/lib/graph_variables.php on line: 149
--
2019/11/12 00:32:10 - CMDPHP PHP ERROR NOTICE Backtrace: (/graph_json.php[158]:rrdtool_function_graph(), /lib/rrd.php[1586]:variable_nth_percentile(), /lib/graph_variables.php[430]:nth_percentile(), /lib/graph_variables.php[33]:rrdtool_function_stats(), /lib/graph_variables.php[136]:nth_percentile_fetch_statistics(), /lib/graph_variables.php[149]:CactiErrorHandler())
2019/11/12 00:32:10 - ERROR PHP NOTICE: Undefined index: values in file: /var/www/html/cacti/lib/graph_variables.php on line: 149
2019/11/12 00:32:10 - CMDPHP PHP ERROR NOTICE Backtrace: (/graph_json.php[158]:rrdtool_function_graph(), /lib/rrd.php[1586]:variable_nth_percentile(), /lib/graph_variables.php[430]:nth_percentile(), /lib/graph_variables.php[33]:rrdtool_function_stats(), /lib/graph_variables.php[132]:nth_percentile_fetch_statistics(), /lib/graph_variables.php[208]:CactiErrorHandler())

@cigamit
Copy link
Member

cigamit commented Nov 27, 2019

Okay, making a small change in lib/graph_variables.php. Test it.

@cigamit cigamit added the resolved A fixed issue label Nov 27, 2019
@cigamit cigamit added this to the v1.2.8 milestone Nov 27, 2019
@cigamit cigamit added the bug Undesired behaviour label Nov 27, 2019
@cigamit
Copy link
Member

cigamit commented Nov 27, 2019

You can reproduce by viewing a 95th ptile graph in realtime. Make sure you purge the realtime cache before you test.

@cigamit
Copy link
Member

cigamit commented Dec 6, 2019

No feedback.

@cigamit cigamit closed this as completed Dec 6, 2019
@interduo
Copy link
Contributor Author

interduo commented Dec 7, 2019

This was resolved by commits. Thanks.

@netniV netniV changed the title Errors after sync to 1.2.x When viewing graphs in realtime, undefined variable can be logged for 95th Percentile graphs Dec 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants