Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph template 'Linux - Memory Usage' has the wrong unit on its vertical_label #3099

Closed
YongBoLiu opened this issue Nov 20, 2019 · 7 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@YongBoLiu
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.
The vertical_label unit kilobytes is wrong on graph template 'Linux - Memory Usage' . It should be Bytes.
When my Linux cacti server has 23G memory free. The graph shows 23G, which is OK. But the vertical lable show kilobytes. It's wrong, should be Bytes.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Console->graphs.
  2. Click on the Local Linux Machine - Memory Usage graph.
  3. Check the vertical lable on the graph.

Expected behavior
A clear and concise description of what you expected to happen.
Change the kilobytes to Bytes.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]
    Linux

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

The script (#perl cacti/scripts/linux_memory.pl) returns value in KB, and the graph item use 'Multiply by 1024'. So, the value result in Bytes.

The file Local_Linux_Machine.xml seems be encoded, after gzip the cacti/install/templates/Local_Linux_Machine.xml.gz.

@YongBoLiu
Copy link
Contributor Author

unit_wrong

@netniV
Copy link
Member

netniV commented Nov 20, 2019

So, one of two things is wrong then, either the label should become bytes or the values should have been divided by 1024 but are not... Not sure if @cigamit changed that in the last year or not without searching which I can't do right now.

@YongBoLiu
Copy link
Contributor Author

@netniV I prefer to change the label to bytes, because this makes the value more straightforward. Otherwise, we may get the value, 3G as shown 3M of KB. Thanks.

@netniV
Copy link
Member

netniV commented Nov 21, 2019

Yeah I can agree with that assume the label doesn't adjust itself which your example suggests it does not.

@cigamit cigamit added the bug Undesired behaviour label Nov 26, 2019
cigamit added a commit that referenced this issue Nov 28, 2019
The vertical_label unit kilobytes is wrong on graph template 'Linux - Memory Usage'
@cigamit cigamit added the resolved A fixed issue label Nov 28, 2019
@cigamit
Copy link
Member

cigamit commented Nov 28, 2019

This is resolved now with the updated Local Linux Machine package.

@cigamit cigamit closed this as completed Nov 28, 2019
@cigamit cigamit added this to the v1.2.8 milestone Nov 28, 2019
@netniV
Copy link
Member

netniV commented Nov 29, 2019

One thing is that we may need to make the installer allow re-installation of packages

@cigamit
Copy link
Member

cigamit commented Nov 29, 2019

We really need a 'Package' option on the Import/Export page as well, one that can install packages from a local file system, or directly download and install them from GitHub. But instead of making a new option, we just allow them to specify package or template on the import export picks.

@netniV netniV changed the title The vertical_label unit kilobytes is wrong on graph template 'Linux - Memory Usage' Graph template 'Linux - Memory Usage' has the wrong unit on its vertical_label Dec 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants