Skip to content

When viewing graphs, a byref error can be seen in the error logs #3104

Closed
@reubenfarrelly

Description

@reubenfarrelly

I'm following git 1.2.x branch, and a commit somewhere around d5f9867 has broken things all over again.

After updating to anything past this commit I now get this logged, and a server side error:

[Wed Nov 27 17:06:07.199325 2019] [php7:error] [pid 3756:tid 140394685986560] [client 2403:5800:7100:911::50:58253] PHP Fatal error: Uncaught Error: Cannot pass parameter 5 by reference in /var/www/cacti.reub.net/htdocs/graph_json.php:158\nStack trace:\n#0 {main}\n thrown in /var/www/cacti.reub.net/htdocs/graph_json.php on line 158, referer: https://cacti.reub.net/graph_view.php?action=preview
[Wed Nov 27 17:06:07.207148 2019] [php7:error] [pid 3756:tid 140394711164672] [client 2403:5800:7100:911::50:58253] PHP Fatal error: Uncaught Error: Cannot pass parameter 5 by reference in /var/www/cacti.reub.net/htdocs/graph_json.php:158\nStack trace:\n#0 {main}\n thrown in /var/www/cacti.reub.net/htdocs/graph_json.php on line 158, referer: https://cacti.reub.net/graph_view.php?action=preview

It is browser independent and shows up in Tree View (is anyone even testing Tree View? This is the second fatal problem in a month to break this view...) Preview and List Views still work OK though.

Reverting d5f9867 results in the error going away, but the page doesn't render graphs.

Problem current as of 1a6ba58 .

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugUndesired behaviourguiUI related issue

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions