Skip to content

Main Data Collector should perform a Full Sync whenever it is installed/upgraded #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cigamit opened this issue Nov 29, 2019 · 0 comments
Closed

Main Data Collector should perform a Full Sync whenever it is installed/upgraded #3119

cigamit opened this issue Nov 29, 2019 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone
v1.2.8

Comments

@cigamit
Copy link
Member

cigamit commented Nov 29, 2019 •
edited
Loading

Describe the bug
When you upgrade the main Cacti Data Collector, attempting to access the remote Data Collectors will essentially stay in an upgrade loop. This is due to the version table being stuck at the prior version in the version table and not matching the version in the core database.

This is tricky, and is a timing issue since if the replication has not started and succeeded, this replication may cause the tables to be moved ahead of the files. So, maybe instead, as a part of the replicate out, we might want to detect a version change, and perform the full sync automatically for the remote collectors that are online.

To Reproduce
Steps to reproduce the behavior:

  1. Upgrade a main cacti server
  2. Wait for a file sync, which includes the cacti_version file
  3. After file sync is completed, attempt to login to the remote data collector
  4. Note you are stuck in an install loop

Expected behavior
Either upgrade should happen including a full sync, or the upgrade of the main server should include the full sync.
@cigamit cigamit added the bug Undesired behaviour label Nov 29, 2019
@cigamit cigamit added this to the v1.2.8 milestone Dec 1, 2019
cigamit added a commit that referenced this issue Dec 1, 2019
@cigamit
Resolving Issue #3119 and a regression
7685185 
* After Installing Cacti on Main Data Collector, Full Sync should be performed
* Regression on upgrading a second time for 1.2.8
* Note that there remains an issue where the last two lines are missed from the log until you execute on more refresh of the page.
* This changes also finish i18n of the log_install_always function calls.  For some reason, they were not fully i18n and had some issues with the wrong number of parameters in cases.
@cigamit cigamit added the resolved A fixed issue label Dec 1, 2019
@cigamit cigamit closed this as completed Dec 1, 2019
@netniV netniV changed the title After Installing Cacti on Main Data Collector, Full Sync should be performed Main Data Collector should perform a Full Sync whenever it is installed/upgraded Dec 7, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Milestone
v1.2.8
Development

No branches or pull requests
1 participant
@cigamit