Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When converting tables during install, show what will be changed #3121

Closed
cigamit opened this issue Nov 30, 2019 · 0 comments
Closed

When converting tables during install, show what will be changed #3121

cigamit opened this issue Nov 30, 2019 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@cigamit
Copy link
Member

cigamit commented Nov 30, 2019

Describe the bug
Currently, when you run the install/upgrade and your tables are in the wrong format, it's not clear what is wrong with the format. Change the output to include information about what is incorrect in the formatting.

To Reproduce
Steps to reproduce the behavior:

  1. Start a new upgrade from Cacti 0.8.8h
  2. When you get to the table conversion, Collation and Engine columns are blank
  3. You have no idea what the current collation, engine, or row format are

Expected behavior
Cacti should give a clearer indication of what is incorrect.

@cigamit cigamit added this to the v1.2.8 milestone Nov 30, 2019
@cigamit cigamit added the bug Undesired behaviour label Nov 30, 2019
cigamit added a commit that referenced this issue Nov 30, 2019
When converting tables during install, show what will be changed
@cigamit cigamit added the resolved A fixed issue label Nov 30, 2019
@cigamit cigamit closed this as completed Nov 30, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant