Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate does not correctly follow color template when reordered #3155

Closed
ISekan opened this issue Dec 24, 2019 · 6 comments
Closed

Aggregate does not correctly follow color template when reordered #3155

ISekan opened this issue Dec 24, 2019 · 6 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@ISekan
Copy link

ISekan commented Dec 24, 2019

If I use Reorder Type (Graph, Data Source) color template does not fit to graph
image
image
If Reorder Type (No reordering) - all's ok
image

@cigamit
Copy link
Member

cigamit commented Dec 24, 2019

Yea, darn. I did not think of that when I did the Re-order fix. Good catch!!!

@cigamit cigamit added the bug Undesired behaviour label Dec 24, 2019
@cigamit cigamit added this to the v1.2.9 milestone Dec 24, 2019
@ISekan
Copy link
Author

ISekan commented Dec 24, 2019

Thanks for quick response and solving the problem

cigamit added a commit that referenced this issue Dec 24, 2019
Aggregate Reorder Type & color template
@cigamit
Copy link
Member

cigamit commented Dec 24, 2019

Please update lib/api_aggregate.php from the 1.2.x branch, then change the Reorder, save, and then back to the desired Reorder and save again. Let me know if they are proper now.

@cigamit cigamit added the resolved A fixed issue label Dec 24, 2019
@cigamit
Copy link
Member

cigamit commented Dec 24, 2019

It's not fixed. Does not cover the Data Source, Graph reordering.

@cigamit cigamit removed the resolved A fixed issue label Dec 24, 2019
cigamit added a commit that referenced this issue Dec 24, 2019
This handles the Data Source, Graph reorder type properly.
@cigamit
Copy link
Member

cigamit commented Dec 24, 2019

Okay, should be okay now.

@ISekan
Copy link
Author

ISekan commented Dec 25, 2019

Thanks! I'm just waiting for 1.2.9

@cigamit cigamit added the resolved A fixed issue label Jan 4, 2020
@cigamit cigamit closed this as completed Jan 4, 2020
@netniV netniV changed the title Aggregate Reorder Type & color template Aggregate does not correctly follow color template when reordered Feb 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants