Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back button not working properly with Classic theme #3157

Closed
Susanin63 opened this issue Dec 24, 2019 · 3 comments
Closed

Back button not working properly with Classic theme #3157

Susanin63 opened this issue Dec 24, 2019 · 3 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@Susanin63
Copy link
Contributor

Susanin63 commented Dec 24, 2019

I'm having and issue where the browser back button does not return to the previous page in certain instances.
Clear 1.2.8 install. Admin profile - choose Classic theme. After that click on main menu Console - Management and after that menu "Devices","Sites","Trees". Then click Back button on browser. Link adress will change, but browser don't update data.

Another theme work fine.
Tested on FF and Chrome last version.
In layout.js 2485 don't fired.

Additional context

	$('#filter, #rfilter').keydown(function(event) {
		if (event.keyCode == 8 && $(this).val() == '') {
			handlePopState();
		}
	});

not fired in any themes.

@cigamit
Copy link
Member

cigamit commented Dec 24, 2019

Well, that code is to prevent the backspace from triggering a back action when your cursor is inside the filter and you backspace to the beginning. So, that's not the place. Going to trace this one.

@cigamit
Copy link
Member

cigamit commented Dec 24, 2019

Well, that's odd. The jQuery function was not triggering on Classic for some unknown reason.

@cigamit cigamit added the bug Undesired behaviour label Dec 24, 2019
@cigamit cigamit added this to the v1.2.9 milestone Dec 24, 2019
@cigamit cigamit changed the title back button not working (1.2.8) Back button not working in all cases in 1.2.8 Dec 24, 2019
cigamit added a commit that referenced this issue Dec 24, 2019
Back button not working in all cases in 1.2.8
@cigamit cigamit added the resolved A fixed issue label Dec 24, 2019
@Susanin63
Copy link
Contributor Author

Now it works better, but not perfect.
Tested on Classic and Modern theme. Open cacti and open link: Managment -> Devices, Sites, Trees and the remaining 8 links in turn. After that press Back button one time.
Adress will be:
...../plugins/thold/notify_lists.php?nostate=true
press Back button one more time:
...../plugins/thold/notify_lists.php - but we have the same content
press Back button one more time:
...../aggregate_graphs.php?nostate=true - this work correct
press Back button one more time:
and we have blank page!

tested on normal and private mode on Chrome 79.0.3945.88 (x64)

cigamit added a commit that referenced this issue Jan 4, 2020
Installer should initialize the csrf-secret.php file automatically
@cigamit cigamit closed this as completed Jan 4, 2020
@netniV netniV changed the title Back button not working in all cases in 1.2.8 Back button not working properly with Classic theme Feb 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants