Skip to content

Back button not working properly with Classic theme #3157

Closed

Description

@Susanin63

I'm having and issue where the browser back button does not return to the previous page in certain instances.
Clear 1.2.8 install. Admin profile - choose Classic theme. After that click on main menu Console - Management and after that menu "Devices","Sites","Trees". Then click Back button on browser. Link adress will change, but browser don't update data.

Another theme work fine.
Tested on FF and Chrome last version.
In layout.js 2485 don't fired.

Additional context

	$('#filter, #rfilter').keydown(function(event) {
		if (event.keyCode == 8 && $(this).val() == '') {
			handlePopState();
		}
	});

not fired in any themes.

Activity

  1. cigamit commented on Dec 24, 2019

    @cigamit
    Member

    Well, that code is to prevent the backspace from triggering a back action when your cursor is inside the filter and you backspace to the beginning. So, that's not the place. Going to trace this one.

  2. cigamit commented on Dec 24, 2019

    @cigamit
    Member

    Well, that's odd. The jQuery function was not triggering on Classic for some unknown reason.

  3. added this to the v1.2.9 milestone on Dec 24, 2019
  4. changed the title [-]back button not working (1.2.8)[/-] [+]Back button not working in all cases in 1.2.8[/+] on Dec 24, 2019
  5. added a commit that references this issue on Dec 24, 2019
  6. Susanin63 commented on Dec 26, 2019

    @Susanin63
    ContributorAuthor

    Now it works better, but not perfect.
    Tested on Classic and Modern theme. Open cacti and open link: Managment -> Devices, Sites, Trees and the remaining 8 links in turn. After that press Back button one time.
    Adress will be:
    ...../plugins/thold/notify_lists.php?nostate=true
    press Back button one more time:
    ...../plugins/thold/notify_lists.php - but we have the same content
    press Back button one more time:
    ...../aggregate_graphs.php?nostate=true - this work correct
    press Back button one more time:
    and we have blank page!

    tested on normal and private mode on Chrome 79.0.3945.88 (x64)

  7. added a commit that references this issue on Jan 4, 2020
  8. changed the title [-]Back button not working in all cases in 1.2.8[/-] [+]Back button not working properly with Classic theme[/+] on Feb 10, 2020
  9. locked and limited conversation to collaborators on Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugUndesired behaviourresolvedA fixed issue

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions