Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classic theme show only 3 tabs on mobile device. Don't show Console menu #3158

Closed
Susanin63 opened this issue Dec 26, 2019 · 8 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue

Comments

@Susanin63
Copy link
Contributor

On classic theme on mobile device don't work pinch zoom. Because of this, only 3 tabs are visible and the main menu is hidden after half a second. Video is attached.

Xiaomi MiMIX 2S 5.99" and 2160x1080
cacti

@Susanin63
Copy link
Contributor Author

And old version (0.8.8f) on that device looks like this:
cacti_old _

@netniV
Copy link
Member

netniV commented Dec 27, 2019

I think there should be a tab with three dots in it for the drop down part, but I can't recall if that applies to classic.

@TheWitness
Copy link
Member

Presently, it does not. I checked the code. I'm not sure how much work it is to fix though. Maybe we just don't hide under that theme.

@netniV
Copy link
Member

netniV commented Dec 30, 2019

I think given this is a "Classic" theme, that's probably the easiest answer.

@Susanin63
Copy link
Contributor Author

or change one line a little:
lib\html.php:2296
<meta content='width=device-width, initial-scale=0.5, minimum-scale=0.2, maximum-scale=2.0' name='viewport'>

to make the pinch-zoom work again

@TheWitness
Copy link
Member

Maybe that's better for the classic theme. For the others, they handle the tab hiding and showing just fine.

TheWitness added a commit that referenced this issue Jan 2, 2020
Classic theme show only 3 tabs on mobile device. Don't show Console menu
@TheWitness TheWitness added bug Undesired behaviour resolved A fixed issue labels Jan 2, 2020
@TheWitness
Copy link
Member

Test the latest lib/html.php.

@Susanin63
Copy link
Contributor Author

Now it is work!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants