Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the poller_output_boost table is missing, recreate it before a poller run #3161

Closed
TheWitness opened this issue Dec 31, 2019 · 1 comment
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

TheWitness commented Dec 31, 2019

Describe the bug
When updating from an older version of Cacti, it's possible for the poller_output_boost to be missing. We should check for this case, and repair it before each poller run.

To Reproduce
It is difficult to reproduce, but I was able to reproduce at a customer site.

Expected behavior
The poller_output_boost table should not go missing. The boost process should first create the archive table and the new boost table in one transaction so that it can not end up being missing. Second, since the archive table rows are not properly reported in the information schema database, we should check the actual rows of the table prior to dropping it.

@TheWitness TheWitness added this to the v1.2.9 milestone Dec 31, 2019
@TheWitness TheWitness added the bug Undesired behaviour label Dec 31, 2019
@TheWitness
Copy link
Member Author

It looks like @cigamit fixed this issue here 4d89902#diff-4b712304f74a7ead3245e7f73ad675a1. However, it would be good to perform a few additional remediation steps.

@TheWitness TheWitness changed the title If for some reason the boost process is inturrupted the boost table can become missing If for some reason the poller_output_boost table is missing, recreate it before a poller run Dec 31, 2019
TheWitness added a commit that referenced this issue Dec 31, 2019
If for some reason the poller_output_boost table is missing, recreate it before a poller run
@TheWitness TheWitness added the resolved A fixed issue label Dec 31, 2019
@cigamit cigamit closed this as completed Jan 4, 2020
@netniV netniV changed the title If for some reason the poller_output_boost table is missing, recreate it before a poller run When the poller_output_boost table is missing, recreate it before a poller run Feb 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants