Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When configuration file is unreadable, Cacti shows database connection errors if non defaults are needed #3181

Closed
netniV opened this issue Jan 12, 2020 · 3 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@netniV
Copy link
Member

netniV commented Jan 12, 2020

Describe the bug
When the include/config.php is unreadable, Cacti reports a database connection error if non defaults are needed.

To Reproduce
Steps to reproduce the behavior:

  1. Create Cacti Database/User as something other than 'cactiuser' on localhost
  2. Set permissions on config.php to be unreadable
  3. Launch cacti website or cli program
  4. See error

Expected behavior
Cacti should report that the configuration file is unreadable as other settings may also be unset as a result.

netniV added a commit that referenced this issue Jan 12, 2020
This commit adds a notice when configphp is present but unreadable.  It also adds the ability to display any database connection errors that occur within db_connect_real for diagnostic purposes.  These notices are only presented to the end user when the appropriate flag is set as most users do not need them.

Closes #3181 and closes #3182
@cigamit cigamit added the bug Undesired behaviour label Jan 16, 2020
@cigamit
Copy link
Member

cigamit commented Feb 2, 2020

@netniV, isn't this one fixed already?

@netniV
Copy link
Member Author

netniV commented Feb 2, 2020

I believe that it was. I thought it was in the CHANGELOG already but I’d have to look

@netniV
Copy link
Member Author

netniV commented Feb 3, 2020

When i looked on my phone it didn't show the commit but it is above.

@netniV netniV closed this as completed Feb 3, 2020
@netniV netniV added this to the v1.2.9 milestone Feb 3, 2020
@netniV netniV added the resolved A fixed issue label Feb 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants