Improve program path detection by using system path and PHP_BINDIR

[browniebraun]

Module detection fails on a blank system if PHP has been installed in non-default location and in combination with PHP-FPM. path_php_binary is empty per default.

[netniV]

Can you be more specific about how it is failing with examples of configuration and more description of the problem

[browniebraun]

Will add some screenshots once I'm back in the office tomorrow morning.

[netniV]

Thanks, I'll take a look tomorrow then.

[netniV]

So, I've improved the program path detection code so that it now has our predefined list of folders, but it will also include the system path and PHP_BINDIR as a priority.

php > include('/usr/share/cacti/site/install/functions.php');
php > print_r (find_search_paths());
Array
(
    [0] => /usr/local/sbin
    [1] => /usr/local/bin
    [2] => /usr/sbin
    [3] => /usr/bin
    [4] => /sbin
    [5] => /bin
    [6] => /usr/games
    [7] => /usr/local/games
    [14] => /usr/local/spine/bin
    [15] => /usr/spine/bin
)

php > putenv('PHP_BINDIR=/bin');
php > print_r (find_search_paths());
Array
(
    [0] => /bin
    [1] => /usr/local/sbin
    [2] => /usr/local/bin
    [3] => /usr/sbin
    [4] => /usr/bin
    [5] => /sbin
    [7] => /usr/games
    [8] => /usr/local/games
    [15] => /usr/local/spine/bin
    [16] => /usr/spine/bin
)

php > putenv('PATH=/my/path1:/usr/local/bin:/mypath2');
php > print_r (find_search_paths());
Array
(
    [0] => /bin
    [1] => /my/path1
    [2] => /usr/local/bin
    [3] => /mypath2
    [5] => /sbin
    [6] => /usr/bin
    [7] => /usr/sbin
    [9] => /usr/local/sbin
    [10] => /usr/local/spine/bin
    [11] => /usr/spine/bin
)

As you can see, by setting the PATH or PHP_BINDIR changes the order of searching but also includes directories that might have been otherwise missed.

[netniV]

@BSOD2600 may want to double check this on the windows side but I did specify that the path separator is a semi colon (;) rather than colon (:) which unix uses so in theory the code should work the same.

[TheWitness]

I've found some customers who have their own PHP versions installed on NFS and added to their PATHs that don't match the install requirements of Cacti, and that this messes up the CLI but not the GUI.

We should be compensating for that somehow. I would prefer we always pick local paths, though that would be hard to detect, though not impossible. Maybe forcing a path in config.php is an option too.

[netniV]

Setting PHP_BINDIR will override all else. We could add a similar config variable as another step, but then which takes priority?

[TheWitness]

I would say if you set it in config.php, it is right at the top of the array.