Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimize use of eval() in JavaScript due to emerging Content-Security-Context guidelines #3196

Closed
TheWitness opened this issue Jan 16, 2020 · 1 comment
Labels
3rd Party Bug 3rd party bug bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug
Browsers are not requiring Content-Security-Contexts in the browsers header in meta tags or, by default, content is not viewable.

Expected behavior
Cacti should refrain from dependency of eval() within the code, as well as using inline JavaScript.

Inline JavaScript is also problematic to many security professionals and should also be avoided. However, Cacti 1.2.x leverages in inline JavaScript extensively, though evals() are only used in select areas. Therefore, inline JavaScript removal will have to wait for Cacti 1.3 before being extracted.

@TheWitness TheWitness added bug Undesired behaviour 3rd Party Bug 3rd party bug labels Jan 16, 2020
@TheWitness
Copy link
Member Author

TheWitness commented Jan 16, 2020

Noting additionally that the following are using eval:

  • most cacti themes
  • jquery.timepicker.js
  • jquery.zoom.js
  • jquery.metadata.js - which is not in use and should be removed from the Cacti distribution

@TheWitness TheWitness added the resolved A fixed issue label Jan 16, 2020
@TheWitness TheWitness added this to the v1.2.9 milestone Jan 16, 2020
@netniV netniV changed the title Minimuze use of eval() in JavaScript due to emerging Content-Security-Contexts guidelines Minimize use of eval() in JavaScript due to emerging Content-Security-Contexts guidelines Jan 17, 2020
@TheWitness TheWitness changed the title Minimize use of eval() in JavaScript due to emerging Content-Security-Contexts guidelines Minimize use of eval() in JavaScript due to emerging Content-Security-Context guidelines Jan 17, 2020
cigamit added a commit that referenced this issue Jan 24, 2020
Minimize use of eval() in JavaScript due to emerging Content-Security-Context guidelines
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3rd Party Bug 3rd party bug bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant