Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted aggregate graph cannot be edited #3206

Closed
ghost opened this issue Jan 20, 2020 · 4 comments
Closed

Converted aggregate graph cannot be edited #3206

ghost opened this issue Jan 20, 2020 · 4 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@ghost
Copy link

ghost commented Jan 20, 2020

A converted aggregate graph cannot be edited via the web UI. As soon as the edit form is submitted, the graph breaks.

Steps to reproduce the behavior:

  1. Convert existing aggregate graph to normal graph
  2. Visit edit view of converted graph
  3. Hit the save button
  4. Graph preview and edit view is different

Part of edit view and graph before:
agg_fine

Edit view and graph after hitting save:
agg_broken

This issue occurs on v1.2.8 (also observed in 1.2.7, can't say for previous versions)

@TheWitness
Copy link
Member

Can you update to 1.2.9 and see if you can repeat this?

@TheWitness
Copy link
Member

Oh, I just reproduced.

TheWitness added a commit that referenced this issue Jan 23, 2020
Converted aggregate graph cannot be edited
@TheWitness TheWitness added bug Undesired behaviour resolved A fixed issue labels Jan 23, 2020
@TheWitness TheWitness added this to the v1.2.9 milestone Jan 23, 2020
@TheWitness
Copy link
Member

This should be fixed now. Just update graphs.php from the 1.2.x branch.

@ghost
Copy link
Author

ghost commented Jan 23, 2020

Can confirm it's working fine now. Very nice, thanks!

@ghost ghost closed this as completed Jan 23, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant