Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing HRULE and VRULE items, color selector was not presented #3232

Closed
frontierliu opened this issue Feb 5, 2020 · 2 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@frontierliu
Copy link
Contributor

frontierliu commented Feb 5, 2020

Version: Cacti 1.2.8, 1.2.9

When I edit graph template's item of HRULE or VRULE , I can change its color in item_edit page as below:
QQ图片20200205104857

But When I edit graph's item of HRULE or VRULE, the color selector dispears in item_edit page, and I think it is unreasonable, as below:
QQ截图20200205104700

HRULE and VRULE edit page should keep color option selector and other options in graph, as graph_template do.

how to resolv:
in graphs_items.php
line 601: $('#row_color_id').hide(); change to : $('#row_color_id').show();
line 613: $('#row_text_format').hide(); change to : $('#row_text_format').show();
line 618: $('#row_color_id').hide(); change to : $('#row_color_id').show();
line 630: $('#row_text_format').hide(); change to: $('#row_text_format').show();

@cigamit
Copy link
Member

cigamit commented Feb 6, 2020

Oh, this is interesting.

cigamit added a commit that referenced this issue Feb 6, 2020
HRULE and VRULE shoud have color option selector when one edit item of graph
@cigamit cigamit added bug Undesired behaviour resolved A fixed issue labels Feb 6, 2020
@cigamit cigamit added this to the v1.2.9 milestone Feb 6, 2020
@cigamit
Copy link
Member

cigamit commented Feb 6, 2020

Thanks for catching this.

@netniV netniV changed the title HRULE and VRULE shoud have color option selector when one edit item of graph. When editing HRULE and VRULE items, color selector was not presented Feb 10, 2020
@netniV netniV closed this as completed Feb 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants