Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installer shows script owner rather than running user for suggested chown command #3254

Closed
eschoeller opened this issue Feb 11, 2020 · 2 comments
Assignees
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@eschoeller
Copy link

The permissions commands suggestion box is awfully useful.

But the user:group is never accurate on my system. I run the webserver as user 'apache'. I imagine others do as well. The installer always suggests to 'chown -R root:root ...'. Would it be relatively easy to determine the correct user:group of the running webserver through an environment variable and then reflect that in the permissions suggestion?

No worries if it's too much hassle or too error prone. It's just something I've been thinking of for awhile.

@netniV
Copy link
Member

netniV commented Feb 12, 2020

I think someone has done something with that, because on my system, it showed the owner of the folder rather than website user. I had planned to investigate that, but now I will definitely have to because theirs an open issue ;-)

@netniV netniV self-assigned this Feb 21, 2020
@netniV netniV added the bug Undesired behaviour label Feb 21, 2020
@netniV netniV added this to the 1.2.10 milestone Feb 21, 2020
@netniV netniV changed the title Installer Permissions Suggestions - Webserver owner Installer shows file owner rather than running user for suggested chown command Feb 21, 2020
@netniV netniV changed the title Installer shows file owner rather than running user for suggested chown command Installer shows script owner rather than running user for suggested chown command Feb 21, 2020
netniV added a commit that referenced this issue Feb 21, 2020
@netniV netniV added the resolved A fixed issue label Feb 21, 2020
@netniV
Copy link
Member

netniV commented Feb 21, 2020

Someone had been tampering, so i've tampered again and improved on my original stuff to use the posix functions if they are available for speedier use.

@netniV netniV closed this as completed Feb 21, 2020
netniV added a commit that referenced this issue Feb 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants