Packages that are not properly formatted can cause installation issues

[nuno-silva]

The cacti installer is broken on fresh install of 1.2.10.

The GUI shows an "action failed" message with a few warnings:

Action failed
Sorry, we could not process your last action.
Error:	200 OK
Reason:	
Notice: Undefined index: name in /var/www/cacti-testing/htdocs/cacti/lib/installer.php on line 1079

Notice: Undefined index: name in /var/www/cacti-testing/htdocs/cacti/lib/installer.php on line 1080

Notice: Undefined index: name in /var/www/cacti-testing/htdocs/cacti/lib/installer.php on line 1081

Notice: Undefined index: name in /var/www/cacti-testing/htdocs/cacti/lib/installer.php on line 1088
{"Mode":1,"Step":1,"Errors":[],"Eula":null,"Prev":{"Text":"Previous","Step":0,"Enabled":false,"Visible":true},"Next":{"Text":"Begin","Step":2,"Enabled":false,"Visible":true},"Test":{"Text":"Test Connection","Step":-4,"Enabled":true,"Visible":false},"Theme":"modern","StepData":{"Eula":null,"Theme":"modern","Language":"en-US"},"Html":"

Also see attached screenshot.

To Reproduce
Steps to reproduce the behavior:

1. Install a fresh copy of cacti 1.2.10
2. Populate the cacti database (using cacti.sql)
3. Edit include/config.php with your DB settings
4. Point your browser to the installation site.
5. See error

Expected behaviour
Installer should proceed normally and without warnings.

Screenshots

Desktop

• OS: Gentoo Linux
• Browser: Chromium 80.0.3987.122 (Developer Build) (64-bit)

Additional context

• PHP 7.2.27

This is somewhat similar to #3323, except this is a fresh install, not an upgrade.

Removing 'Cacti_Stats.xml.gz' from install/functions.phpdoes allow the installation to continue.

[cigamit]

This is now fixed again in the 1.2.x branch including the updated Cacti Stats package. I'll be part of the 1.2.11 release.

[mckaygerhard]

this stupid error still persist! how developers can release a broken version? where's the real fix commit due after applied 501009a there's no files or fixeds .. neither commit 8e68706 not fix anything!

[netniV]

I could quite easily ask:

How can people not search properly to find a simple fix?

I would suggest before berating people, you try asking nicely for help. For now, this was fixed and verified.