Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When attempting to rewrite octet strings, extra space breaks pattern matching #3346

Closed
browniebraun opened this issue Mar 12, 2020 · 1 comment
Labels
bug Undesired behaviour resolved A fixed issue

Comments

@browniebraun
Copy link
Member

I have just found a tiny, but really nasty bug in /lib/data_query.php, line 1119.
There is a space in the pattern (at '}) {2') that breaks the recognition of octet strings like e.g. '5.103.101.48.47.49'

if (preg_match('/^\d{1,3}(\.\d{1,3}) {2,}$/', $parse_value)) {

@TheWitness TheWitness added the bug Undesired behaviour label Mar 12, 2020
TheWitness added a commit that referenced this issue Mar 12, 2020
Broken rewrite of octet strings
@TheWitness TheWitness added the resolved A fixed issue label Mar 12, 2020
@TheWitness
Copy link
Member

Fixed @browniebraun

@netniV netniV changed the title Broken rewrite of octet strings When attempting to rewrite octet strings, extra space breaks pattern matching Apr 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants