Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect breadcrumb bar if current tab is not "Graphs" #3390

Closed
ddb4github opened this issue Mar 31, 2020 · 3 comments
Closed

Incorrect breadcrumb bar if current tab is not "Graphs" #3390

ddb4github opened this issue Mar 31, 2020 · 3 comments
Labels
bug Undesired behaviour

Comments

@ddb4github
Copy link
Contributor

ddb4github commented Mar 31, 2020

Describe the bug
Incorrect navigation bar if current tab is not "Graphs", including "Console"

To Reproduce
Steps to reproduce the behavior:

  1. Switch theme to show "navigation bar(bread crumb)", e.g. Dark, Modern
  2. Click "Graphs" tab
  3. Click any tree node to show some graphs
  4. Click other "Non-Graphs" tab, e.g. "Console"
  5. Check "navigation bar" , see error.

Expected behavior
Navigation bar should keep consistent with current web page.

Screenshots
image

@ddb4github ddb4github changed the title Incorrect navigation bar if current tab is not "Graphs" Incorrect breadcrumb bar if current tab is not "Graphs" Mar 31, 2020
@TheWitness
Copy link
Member

That is some sort of recent regression I think.

@TheWitness TheWitness added the bug Undesired behaviour label Mar 31, 2020
TheWitness added a commit that referenced this issue Mar 31, 2020
* Incorrect breadcrumb bar if current tab is not "Graphs"
* Also use html over the data variable
@TheWitness
Copy link
Member

Should be resolved. Please test and provide feedback.

@ddb4github
Copy link
Contributor Author

Test pass

@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour
Projects
None yet
Development

No branches or pull requests

2 participants