Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cacti scores low on performance audit on lighthouse audit #3402

Closed
TheWitness opened this issue Apr 4, 2020 · 2 comments
Closed

Cacti scores low on performance audit on lighthouse audit #3402

TheWitness opened this issue Apr 4, 2020 · 2 comments
Labels
bug Undesired behaviour performance Performance related affects big sites resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

TheWitness commented Apr 4, 2020

Describe the bug
Cacti is scoring low from a performance perspective on the lighthouse audit available in Chrome. This bug will cover a set of changes that improve that score, but may not resolved all issues.

To Reproduce
Steps to reproduce the behavior:

  1. Open the Cacti website using chrome
  2. Press F-12 on Windows to bring up developers tools
  3. Goto the Audit tab and run the audit
  4. See score

Expected behavior
Cacti should behave as best as possible, knowing that some performance hit's can not be addressed except by the customer due to the OSS nature of the tool.

Screenshots
image

TheWitness added a commit that referenced this issue Apr 4, 2020
* Cacti scores low on performance audit on lighthouse audit
* This change enables generic caching of pages, but with a very short age for RRDtool generated graphics.
* It increses the SEO score through the use of specialty tags on anchors leveraging the _blank target attribute value
* It removes and unnecessary tooltip on the document element

There may be additional changes forthcoming.  However, these changes raised the score from 0 to the mid twenties.

Some of the changes, like minification of JavaScript we do not do due to the nature of the project, but could be done by customers.  Once the page is first rendered, it's in the browsers memory and cached for a good time, so this is not a big deal.
@TheWitness TheWitness added this to the 1.2.11 milestone Apr 4, 2020
@TheWitness TheWitness added bug Undesired behaviour performance Performance related affects big sites labels Apr 4, 2020
@TheWitness
Copy link
Member Author

New score after tuning.

image

TheWitness added a commit that referenced this issue Apr 4, 2020
* These changes allow some JavaScript to be loaded Async.  jQuery and jQueryUI as well as layout.js as well as the themes's main.js are critical and can not be loaded async.
* It also adds the meta description tag to increse the SEI scrore
TheWitness added a commit that referenced this issue Apr 4, 2020
* We were tracking the mousemove of the entire page instead of just the two areas which lead to excessive triggering on the page.
* This change does raise again the Audit score.
TheWitness added a commit that referenced this issue Apr 4, 2020
On a few pages, these JavaScript elements become crucial
The no-cache does not actually mean 'no-cache'.
TheWitness added a commit that referenced this issue Apr 4, 2020
Errors happen when you direct link to the Graphs page.
@TheWitness
Copy link
Member Author

I think the performance number is deceptive, since the items it's complaining about are already cached. So, it's non-blocking. But this is better than it was when we started and I've see some pages with performance numbers closer to 44.

Reading through the Accessibility score, I did find some real target's for improvement, but those will have to take place in the 1.3+ timeframe, since they have a large scope.

image

@TheWitness TheWitness added the resolved A fixed issue label Apr 5, 2020
TheWitness added a commit that referenced this issue Apr 5, 2020
* Revised 'Content-Security-Policy' tested on FF, Chrome, Edge, Opera and no issues found.
* Adding the Multiselect Filter as it's critical for some initial page loads like the Graphs page for Templates which include the 'Search' functionality.
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour performance Performance related affects big sites resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant