Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with navigation link activations to other base Cacti pages #3409

Closed
TheWitness opened this issue Apr 5, 2020 · 1 comment
Closed
Labels
bug Undesired behaviour gui UI related issue resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug
If you wish to link to say the 'graphs' page from a third party page, the Cacti menu api will loose the selection of the page that was navigated from. Instead Cacti should, if it does not find the link in the current navigation, maintain the prior menu selection.

To Reproduce
Steps to reproduce the behavior:

  1. Create a third party plugin that maintains it's own menu
  2. Have a page on that menu that let's you drill down to the graph_view.php?action=preview, or some other base package without leaving the current navigation
  3. Notice that the selected menu item is de-selected leading to confusion on the page.

Expected behavior
Cacti should keep the prior navigation in place if there is no matching navigation on the in the current menu.

@TheWitness TheWitness added bug Undesired behaviour gui UI related issue resolved A fixed issue labels Apr 5, 2020
@TheWitness TheWitness added this to the 1.2.11 milestone Apr 5, 2020
@TheWitness
Copy link
Member Author

Commit that fixes is here: 512b704#diff-e65e4069723fadf5732290878dd58a2c

@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour gui UI related issue resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant