Skip to content

When Graph Item is not linked to a data source, Comments do not always get variables substituted correctly #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ddb4github opened this issue Apr 6, 2020 · 0 comments
Closed

When Graph Item is not linked to a data source, Comments do not always get variables substituted correctly #3422

ddb4github opened this issue Apr 6, 2020 · 0 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team gui UI related issue resolved A fixed issue
Milestone
1.2.12

Comments

@ddb4github
Copy link
Contributor

Describe the bug

After #2656, rrd_substitute_host_query_data function substitute graph item text_format from data_local.snmp_query_id only.
If add a COMMENT item without any associated datasource, graph will show as screenshot below.

To Reproduce

Steps to reproduce the behavior:

  1. Edit build-in graph template "Unix - Available Disk Space"
  2. Add a item as below:
    image
  3. Create a graph from DataQuery "Unix - Get Mounted Partitions " under build-in device "Local Linux Machine"
  4. View Graph after while
  5. See error as screenshot below

Expected behavior

|query_xxxx| always be replaced for related data query, whatever from graph or data source.

Screenshots

image
@ddb4github ddb4github added bug Undesired behaviour unverified Some days we don't have a clue labels Apr 6, 2020
@ddb4github ddb4github mentioned this issue Apr 6, 2020
Merged
@netniV netniV added confirmed Bug is confirm by dev team gui UI related issue and removed unverified Some days we don't have a clue labels Apr 7, 2020
@netniV netniV added this to the 1.2.12 milestone Apr 7, 2020
netniV added a commit that referenced this issue Apr 7, 2020
@ddb4github @netniV
Fixed #3422: COMMENT text_format does not replace Data Query (#3423)
134faa5 
* Fixed#3422: COMMENT text_format does not replace Data Query if graph item does not associate to any datasource.

* Fixed#3422: Update CHANGELOG

Co-authored-by: Jing Chen <three_chenjing@sohu.com>
Co-authored-by: Mark Brugnoli-Vinten <netniv@hotmail.com>
@TheWitness TheWitness added the resolved A fixed issue label Apr 9, 2020
@netniV netniV changed the title COMMENT text_format does not replace Data Query When Graph Item is not linked to a data source, Comments do not always get variables substituted correctly May 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team gui UI related issue resolved A fixed issue
Projects
None yet
Milestone
1.2.12
Development

No branches or pull requests
3 participants
@TheWitness @netniV @ddb4github