Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When viewing the installation wizard's directory permission step, items are overlapping unexpectedly #3449

Closed
nuno-silva opened this issue Apr 9, 2020 · 4 comments
Closed

When viewing the installation wizard's directory permission step, items are overlapping unexpectedly #3449

nuno-silva opened this issue Apr 9, 2020 · 4 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
1.2.12

Comments

@nuno-silva
Copy link
Contributor

Describe the bug

In the Directory permission checks step of the installation wizard, the directory paths column is too small to display most paths, resulting in them appearing under the actual "check result" and being unreadable. Perhaps it's just a CSS bug.

To Reproduce

Steps to reproduce the behaviour:

  1. Install fresh cacti 1.2.11

  2. Complete the installation wizard until you reach the "directory permission checks" step

  3. See issue

Expected behavior

Path column should have space for bigger paths.

Screenshots

2020-04-07_cacti_1 2 11_fresh_install

Desktop

  • OS: Gentoo Linux

  • Browser: Chromium

  • Version: 80.0.3987.149 (Developer Build) (64-bit)
@nuno-silva nuno-silva added bug Undesired behaviour unverified Some days we don't have a clue labels Apr 9, 2020
@netniV
Copy link
Member

netniV commented Apr 10, 2020

There seems to be a few Gentoo issues. Are you running the Gentoo with a desktop and chrome on there? The CSS styling seems to have failed, you theme looks like the modern one is that correct?

@nuno-silva
Copy link
Contributor Author

I'm running Chromium on a Gentoo Linux Desktop. Cacti was installed on a Gentoo Linux server. I think I used the Classic theme. I don't think the distribution is relevant, but I can re-test on Ubuntu if you prefer. Is there a quick way I can access the installer page without installing a new instance?

@netniV
Copy link
Member

netniV commented Apr 10, 2020

OK, so that gives me something to look at. Oh, and which web server are you using? Just trying to get all the variables together so I can give a reason chance of replicating the test.

@TheWitness TheWitness removed the unverified Some days we don't have a clue label Apr 12, 2020
@nuno-silva
Copy link
Contributor Author

I'm using nginx with php-fpm and mariadb.

I've just reproduced the bug on an Ubuntu VM running:

  • Ubuntu 18.04.4 LTS (Bionic Beaver)
  • fresh install of cacti v1.2.11
  • classic theme
  • Chromium 80.0.3987.163 Built on Ubuntu , running on Ubuntu 18.04
  • nginx version: nginx/1.14.0 (Ubuntu)
  • php-fpm 7.2.24-0ubuntu0.18.04.4
  • MariaDB 10.1.44-MariaDB-0ubuntu0.18.04.1 Ubuntu 18.04

Here's a screenshot (chromium):
image

And a copy of the rendered page (as saved by Chromium): Cacti Server v1.2.11 - Maintenance.zip

On firefox, it's rendered a little different (classic theme on Mozilla Firefox 75.0):
image

Modern theme is OK (chromuim):
image

luismrsilva added a commit to luismrsilva/cacti that referenced this issue Apr 19, 2020
@luismrsilva
Fix for Cacti#3449
0d4dda2
luismrsilva added a commit to luismrsilva/cacti that referenced this issue Apr 19, 2020
@luismrsilva
Fix overlapping itens in directory permission checks in installation …
7904be5 
…wizard

Issue Cacti#3449.
@luismrsilva luismrsilva mentioned this issue Apr 19, 2020
Merged
luismrsilva added a commit to luismrsilva/cacti that referenced this issue Apr 19, 2020
@luismrsilva
Update CHANGELOG with issue Cacti#3449
44e10ec 
Also, use "overflow-y: auto" instead of "overflow: hidden", which gets the job done (fixes height being 0 when element only contains floated elements), but is safer (won't hide things).
TheWitness pushed a commit that referenced this issue Apr 19, 2020
@luismrsilva
Fix overlapping items in directory permission checks in installation …
90feea3 
…wizard (#3476)

* Fix overlapping itens in directory permission checks in installation wizard

Issue #3449.

* Update CHANGELOG with issue #3449

Also, use "overflow-y: auto" instead of "overflow: hidden", which gets the job done (fixes height being 0 when element only contains floated elements), but is safer (won't hide things).
@TheWitness TheWitness added the resolved A fixed issue label Apr 19, 2020
@TheWitness TheWitness added this to the 1.2.12 milestone Apr 19, 2020
@netniV netniV added the confirmed Bug is confirm by dev team label Apr 26, 2020
@netniV netniV changed the title Items are overlapping in directory permission checks in installation wizard When viewing the installation wizard's directory permission step, items are overlapping unexpectedly May 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
1.2.12
Development

No branches or pull requests
3 participants
@TheWitness @nuno-silva @netniV