Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installing a new remote poller, connection tests can incorrectly fail #3459

Closed
ibatten opened this issue Apr 13, 2020 · 3 comments
Closed
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone

Comments

@ibatten
Copy link

ibatten commented Apr 13, 2020

1.2.11

The connection test for a fresh remote poller fails with 200 parseerror.

The problem appears to be (based on strace-ing the php-fpm process) that the "Content-Length" header in the HTTP response is 0, although the content is a valid {"status":"true"}.

I am not, by any stretch of the imagination, a PHP programmer, but based on blind intuition and a certain amount of other messing around I fixed it by replacing "print json_encode..." with "return json_encode..." in install_test_local_database_connection and install_test_remote_database_connection in install/functions.php.

I also had problems with the final install hanging (running for half an hour, apparently doing nothing other than SELECT ing the install progress variables from the database). I just deleted all the install_% variables from the database and it appeared then to work.

@ibatten ibatten added bug Undesired behaviour unverified Some days we don't have a clue labels Apr 13, 2020
@TheWitness
Copy link
Member

Yea, the loop thing has been breaking a lot of upgrades. To date, we have been unable to reproduce other than there was a bogus package that screwed up some install/upgrades.

@scline
Copy link
Contributor

scline commented Apr 17, 2020

@ibatten manual change also fixed this issue on my install (using centos8 docker container). The issue was also present in 1.2.8 if that helps anything.

scline added a commit to scline/docker-cacti that referenced this issue Apr 17, 2020
@TheWitness
Copy link
Member

Can someone do a pull request on this one to the 1.2.x branch?

scline added a commit to scline/cacti that referenced this issue Apr 17, 2020
scline added a commit to scline/cacti that referenced this issue Apr 17, 2020
TheWitness pushed a commit that referenced this issue Apr 17, 2020
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Apr 19, 2020
@TheWitness TheWitness added this to the 1.2.12 milestone Apr 19, 2020
@netniV netniV added the confirmed Bug is confirm by dev team label Apr 26, 2020
@netniV netniV changed the title new remote poller installation fails during connection test, with fix; 1.2.11 When installing a new remote poller, connection tests can incorrectly fail May 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

4 participants