Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created 'custom_denied' hook to allow customisation of permission denied notifications #3480

Closed
ddb4github opened this issue Apr 19, 2020 · 0 comments
Closed

Created 'custom_denied' hook to allow customisation of permission denied notifications #3480

ddb4github opened this issue Apr 19, 2020 · 0 comments
Labels
confirmed Bug is confirm by dev team enhancement General tag for an enhancement resolved A fixed issue
Milestone
1.2.12

Comments

@ddb4github
Copy link
Contributor

Feature Request

Apply 'custom_denied' hook to permission denied branch in include/auth.php for customized login/logout/denied/timeout interface

Is your feature request related to a problem? Please describe

For graph related permission denied, custom_denied hook had beed added since #2426 for permission_denied.php page.
But for general permission denied, Cacti still show buildin permission denied message.

Describe the solution you'd like

Apply 'custom_denied' hook to permission denied branch in include/auth.php

Describe alternatives you've considered

Merge permission_denied.php and include/auth.php as one entrance.

Additional context

PR #3475 was created for this feature request.
@ddb4github ddb4github added the enhancement General tag for an enhancement label Apr 19, 2020
@ddb4github ddb4github mentioned this issue Apr 19, 2020
Merged
ddb4github pushed a commit to ddb4github/cacti that referenced this issue Apr 19, 2020
Update CHANGELOG for Cacti#3480 (Cacti#3475)
e316ef8
TheWitness pushed a commit that referenced this issue Apr 19, 2020
@ddb4github
Apply 'custom_denied' hook to permission denied branch in include/aut…
a871a05 
…h.php (#3475)

* Add a new UI hook custom_denied like existing hook custom_login/custom_logout_message

* Update CHANGELOG for #3480 (#3475)

Co-authored-by: Jing Chen <three_chenjing@sohu.com>
@TheWitness TheWitness added the resolved A fixed issue label Apr 20, 2020
@TheWitness TheWitness added this to the 1.2.12 milestone Apr 20, 2020
@netniV netniV added the confirmed Bug is confirm by dev team label Apr 26, 2020
@netniV netniV changed the title Apply 'custom_denied' hook to permission denied branch in include/auth.php Created 'custom_denied' hook to allow customisation of permission denied notifications May 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
confirmed Bug is confirm by dev team enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Milestone
1.2.12
Development

No branches or pull requests
3 participants
@TheWitness @netniV @ddb4github