Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph Items can show a double percent sign incorrectly #3496

Closed
YongBoLiu opened this issue Apr 24, 2020 · 1 comment
Closed

Graph Items can show a double percent sign incorrectly #3496

YongBoLiu opened this issue Apr 24, 2020 · 1 comment
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone

Comments

@YongBoLiu
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is.
Edit a graph template, add a graph item, choose the Graph Item Type with 'AREA', Input text such as 'aaa %' in the text format, then save.
Check the graphs base on the graph template, the text in the graph shows 'aaa %%'.

To Reproduce

Steps to reproduce the behavior:

  1. Go to console->templates->graph. edit: Linux - Memory Usage graph template.

  2. Add a graph item, choose the Graph Item Type with 'AREA', Input text such as 'aaa %' in the text format, then save.

  3. Go to console->management->graphs. Check the graphs base on the template.

  4. See the text is 'aaa %%'.

Expected behavior

A clear and concise description of what you expected to happen.
The percent sign(%) should the same as input, not be doubled.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information)

  • OS: [e.g. iOS]
    Linux REHL7

  • Browser [e.g. chrome, safari]

  • Version [e.g. 22]

Smartphone (please complete the following information)

  • Device: [e.g. iPhone6]

  • OS: [e.g. iOS8.1]

  • Browser [e.g. stock browser, safari]
    Firefox68

  • Version [e.g. 22]

Additional context

Add any other context about the problem here.

@YongBoLiu YongBoLiu added bug Undesired behaviour unverified Some days we don't have a clue labels Apr 24, 2020
@TheWitness TheWitness removed the unverified Some days we don't have a clue label Apr 24, 2020
@TheWitness TheWitness added this to the 1.2.12 milestone Apr 24, 2020
@TheWitness TheWitness added the resolved A fixed issue label Apr 24, 2020
@netniV netniV added the confirmed Bug is confirm by dev team label Apr 26, 2020
@netniV
Copy link
Member

netniV commented Apr 26, 2020

I have made a comment on the PR but I will repeat it here. I believe that this is incorrect. We corrected the use of being able to use % in the comments/legends and this regresses that. In reality, the template which has the problem should be updated.

@netniV netniV changed the title percent sign(%) is doubled in graph item of AREA type with text Graph Items can show a double percent sign incorrectly May 3, 2020
netniV added a commit that referenced this issue May 29, 2020
* Fix #3496, percent sign(%) is doubled in graph item of AREA type with text

* feature #3513, Add hooks for plugins to show customize graph source and customize template url

* feature #3513, Update changelog, Add hooks for plugins to show customize graph source and customize template url

* 3579, Fix it is strange that many graphs show as 'Empty Graph'.

* 3579, update change log

* 3586, Add the change log.

Co-authored-by: yboliu <yboliu@oc8636837557.ibm.com>
Co-authored-by: Mark Brugnoli-Vinten <netniv@hotmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants