Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When viewing graph previews, clicking Go or Refresh prevents calendars from working #3505

Closed
yingbaiibm opened this issue Apr 26, 2020 · 3 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone

Comments

@yingbaiibm
Copy link

To Reproduce

Steps to reproduce the behavior:

  1. Go to Graph - preview page

  2. Choose calendar and click refresh, calendar can work well -- ok

  3. Choose calendar and click go, after that calendar can not work well, no response. '

Desktop (please complete the following information)

  • OS: rhel 7 x64

  • Browser FF

  • Version Cacti 1.2.11

@yingbaiibm yingbaiibm added bug Undesired behaviour unverified Some days we don't have a clue labels Apr 26, 2020
@yingbaiibm
Copy link
Author

Screen Shot 2020-04-26 at 10 40 40 AM

Screen Shot 2020-04-26 at 10 40 59 AM

Screen Shot 2020-04-26 at 10 41 34 AM

TheWitness added a commit that referenced this issue Apr 26, 2020
Calendar can not work after click go in graph page
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Apr 26, 2020
@TheWitness TheWitness added this to the 1.2.12 milestone Apr 26, 2020
@netniV netniV added the confirmed Bug is confirm by dev team label Apr 26, 2020
@netniV netniV changed the title Calendar can not work after click go in graph page When viewing graph previews, clicking Go or Refresh prevents calendars from working May 3, 2020
@netniV netniV closed this as completed May 3, 2020
@ddb4github
Copy link
Contributor

Until Cacti 1.2.4, datepicker box can be auto-hide when click anywhere on page.
The latest 1.2.x branch, datepicker box can not be easily hide.
image

Reproduce Steps

  1. Click any date input field, popup datepicker
  2. Refresh page by ajax mode, exception "Click 'Refresh' Button". For example
    • No touching, waiting for auto-refresh (From cacti 1.2.4 - 1.2.13)
    • Select Device, Graphs, .... field fields (From cacti 1.2.10 - 1.2.13)
    • Click Go, Clear(both two 'Clear') button (From cacti 1.2.10 - 1.2.13)
  3. See error, datepicker lost header/bottom as above screenshot.

Workaround

Until Cacti 1.2.4( not test 1.2.5 - 1.2.9)

  • Click anywhere on page, datepicker hide, issue workaround

Since Cacti 1.2.10, even 1.2.x(today)

  1. Click date field or 'cal' icon again, to show a complete datepicker box.
  2. Press esc key, or click 'cal' icon again, or click Refresh button
  3. datepicker hide, issue workaround

TheWitness added a commit that referenced this issue May 14, 2020
When viewing graph previews, clicking Go or Refresh prevents calendars from working
@TheWitness
Copy link
Member

Okay, I'm made additional changes. The reason that the document click was removed was due to the nature of the number of elements causing slow page response. We need to limit the number of elements that receive the click event.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

4 participants