Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks for plugins to show customize graph source and customize template url #3513

Closed
YongBoLiu opened this issue Apr 28, 2020 · 1 comment
Labels
enhancement General tag for an enhancement
Milestone

Comments

@YongBoLiu
Copy link
Contributor

YongBoLiu commented Apr 28, 2020

Feature Request

Is your feature request related to a problem? Please describe

Yes, after auto created huge number of graphs without graph template in my plugin, it shows 'Not Templated' in both 'Source Type' and 'Source name' fields. In Console->Management->Graphs.

We need to provide hooks to customize the 'Source Type' and 'Source name' fields for plugins. Because these graphs without graph template can have some special property for plugin.

A clear and concise description of what the problem is. Ex. I'm always
frustrated when [...]
If no hooks for this, plugin develop have to update the graphs.php again and again after cacti core upgraded.

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've
considered.

Additional context

Add any other context or screenshots about the feature request here.

@YongBoLiu YongBoLiu added the enhancement General tag for an enhancement label Apr 28, 2020
@YongBoLiu
Copy link
Contributor Author

Plugin develop may have its own special templates, can have some special property for plugin. ELIM template. So we need add hooks to make more flexible.

@netniV netniV added this to the v1.3.0 milestone Apr 29, 2020
netniV pushed a commit that referenced this issue May 1, 2020
@netniV netniV closed this as completed May 2, 2020
netniV added a commit that referenced this issue May 29, 2020
* Fix #3496, percent sign(%) is doubled in graph item of AREA type with text

* feature #3513, Add hooks for plugins to show customize graph source and customize template url

* feature #3513, Update changelog, Add hooks for plugins to show customize graph source and customize template url

* 3579, Fix it is strange that many graphs show as 'Empty Graph'.

* 3579, update change log

* 3586, Add the change log.

Co-authored-by: yboliu <yboliu@oc8636837557.ibm.com>
Co-authored-by: Mark Brugnoli-Vinten <netniv@hotmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement General tag for an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants