Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automation incorrectly attempts to use MacTrack to duplicate options #3566

Closed
ddb4github opened this issue May 21, 2020 · 4 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@ddb4github
Copy link
Contributor

Describe the bug

Uncaught Error: Call to undefined function duplicate_mactrack

To Reproduce

  1. Go to 'Console-->Automation-->SNMP Options'
  2. Select any one of 'SNMP Option Set;
  3. Select 'Duplicate' action
  4. Click 'Go'
  5. Click 'Continue'
  6. No response, check 'Logs'
  7. See error
2020/05/21 08:10:58 - CMDPHP PHP ERROR Backtrace:  (CactiShutdownHandler())
2020/05/21 08:10:58 - ERROR PHP ERROR: Uncaught Error: Call to  undefined function duplicate_mactrack() in  /var/www/html/cacti/automation_snmp.php:188 Stack trace: #0  /var/www/html/cacti/automation_snmp.php(47):  form_automation_snmp_actions() #1 {main} thrown in file:  /var/www/html/cacti/automation_snmp.php on line: 188
@ddb4github ddb4github added bug Undesired behaviour unverified Some days we don't have a clue labels May 21, 2020
@netniV
Copy link
Member

netniV commented May 21, 2020

This is actually a completely missing function so may have been named differently.

$ grep duplicate_mactrack * -R
automation_snmp.php:					duplicate_mactrack($selected_items[$i], get_nfilter_request_var('name_format'));
plugins/mactrack/mactrack_snmp.php:					duplicate_mactrack($selected_items[$i], get_nfilter_request_var('name_format'));

When I tried to narrow down on it, the only thing I saw was:

$ cd plugins/mactrack
$ grep duplicate * -R | grep function | grep duplicate
mactrack_device_types.php:function api_mactrack_duplicate_device_type($device_type_id, $dup_id, $device_type_title) {

So I think I'll have to defer to either @cigamit or @TheWitness on this one.

@netniV
Copy link
Member

netniV commented May 21, 2020

Just for completeness, I did run through all the tags assigned so far and none of these releases have that function.

@TheWitness
Copy link
Member

MackTrack. That's a surprise. I think it made it way in when snmp options were peeled away from MacTrack.

TheWitness added a commit that referenced this issue May 21, 2020
Uncaught Error: Call to undefined function duplicate_mactrack
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels May 21, 2020
@TheWitness
Copy link
Member

Some should fix this in MacTrack too. It's fixed in Cacti for sure now.

@netniV netniV added this to the 1.2.13 milestone May 23, 2020
@netniV netniV changed the title Uncaught Error: Call to undefined function duplicate_mactrack Automation incorrectly attempts to use MacTrack to duplicate options Jul 12, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

3 participants