Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing prompts during automation's device creation leads to blank data #3572

Closed
mrjackson opened this issue May 23, 2020 · 2 comments
Closed

Missing prompts during automation's device creation leads to blank data #3572

mrjackson opened this issue May 23, 2020 · 2 comments
Labels
enhancement General tag for an enhancement resolved A fixed issue
Milestone
v1.2.17

Comments

@mrjackson
Copy link

mrjackson commented May 23, 2020 •
edited

Describe the bug

In 1.2.12 when adding a new Device with Automatic Graph Creation enabled, any graph with a data source that has an override enabled for custom data in the datasource is created with blank data instead of prompting as it did in previous versions (1.2.2)

To Reproduce

  1. Enable Automatic Graph Creation. (default)
  2. Add a new device with a template that has an override allowed in a datasource
    image
  3. Page to enter custom data (url) does not show, checking datasource after has a blank field.
    Same results on a fresh install on Debian 10.3 and upgrade from 1.2.2 to 1.2.12 on Slackware 14.2

Expected behavior

After adding a new device, a page should be displayed to enter custom data overrides.
Page shows as expected if graphs are created manually after the device is added.
image

Desktop

  • OS: Windows Server 2012R2
  • Browser Chrome
  • Version 81
@mrjackson mrjackson added bug Undesired behaviour unverified Some days we don't have a clue labels May 23, 2020
@TheWitness
Copy link
Member

Yea, this is a known issue with automation. If you are wanting to override the defaults, you should disable automatic non-Data Query automation.

@TheWitness
Copy link
Member

I'm going to mark this as a feature request as such.

@TheWitness TheWitness added enhancement General tag for an enhancement and removed bug Undesired behaviour unverified Some days we don't have a clue labels Jun 13, 2020
@TheWitness TheWitness added this to the v1.2.17 milestone Mar 24, 2021
@TheWitness TheWitness added the resolved A fixed issue label Mar 24, 2021
TheWitness added a commit that referenced this issue Mar 24, 2021
@TheWitness
Fixing Issues #645 - Check Data Sources before Graph Create
b22dff2 
So, this is not 100% finished yet as it does not currently work with the Remote Agent.  However needed some testers.
This change also deprecates Script Server calls being called without the proc_open() command which was a requirement from the early 2000's for a PHP version I don't even remember.
The change also improves logging when creating graphs via automation.
Lastly, marking #3572 as resolved as it was resolved in another fix over the weekend.
@netniV netniV changed the title Automatic Graph Creation on New Device does not ask for Custom Data Override Entry Missing prompts during automation's device creation leads to blank data Apr 12, 2021
@netniV netniV closed this as completed Sep 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement General tag for an enhancement resolved A fixed issue
Projects
None yet
Milestone
v1.2.17
Development

No branches or pull requests
3 participants
@mrjackson @TheWitness @netniV