Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing graphs and graph templates, back button results in broken page #3598

Closed
TheWitness opened this issue Jun 7, 2020 · 0 comments
Closed
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug

In certain cases, when pressing the back button, you receive a page that is broken. This happens on a few Cacti pages. This ticket is specifically for addressing the Graphs and Graph Templates page.

To Reproduce

Steps to reproduce the behavior:

  1. Edit a Graph Template

  2. Remove a Graph Template Input (which might also break your Template)

  3. Click on another Graph Template Input

  4. Press the Back Button

  5. See the page is not rendered properly.

Expected behavior

Cacti should execute the back button action, but some action types should not be cached in the first place.

Additional context

In this case, the back button will want to goto the previous 'item_remove' page, which will then redirect to a page with a header=false, this results in the error being displayed.

@TheWitness TheWitness added bug Undesired behaviour unverified Some days we don't have a clue labels Jun 7, 2020
@TheWitness TheWitness added this to the 1.2.13 milestone Jun 7, 2020
TheWitness added a commit that referenced this issue Jun 7, 2020
When editing graphs and graph templates, back button results in broken page
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Jun 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant