Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When downgrading, templates are fully selected for install #3599

Closed
netniV opened this issue Jun 8, 2020 · 0 comments
Closed

When downgrading, templates are fully selected for install #3599

netniV opened this issue Jun 8, 2020 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@netniV
Copy link
Member

netniV commented Jun 8, 2020

Describe the bug

Recently, a change was made to default template installation as unticked unless the installation was brand new. This was to prevent issues with updating templates users may have modified and do not realise that they are reseting back to our defaults.

However, if you do downgrade, this change does not seem to take effect as it treats the template section like its a new install and fully selects all templates

To Reproduce

  1. Use 1.2.x branch

  2. Set cacti to 1.2.99 in the version table

  3. Visit cacti and step through installation to template step

  4. See all templates are selected

Expected behavior

As with upgrades, a downgrade should not select any templates

@netniV netniV added bug Undesired behaviour unverified Some days we don't have a clue labels Jun 8, 2020
TheWitness added a commit that referenced this issue Jun 14, 2020
When downgrading, templates are fully selected for install
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Jun 14, 2020
@TheWitness TheWitness added this to the 1.2.13 milestone Jun 14, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants